Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing docs: Branch protection rules takes effect only after 6 seconds #8510

Open
idanovo opened this issue Jan 17, 2025 · 0 comments
Open

Missing docs: Branch protection rules takes effect only after 6 seconds #8510

idanovo opened this issue Jan 17, 2025 · 0 comments
Labels
docs Improvements or additions to documentation product-task

Comments

@idanovo
Copy link
Contributor

idanovo commented Jan 17, 2025 •
edited
Loading

What happened?

Steps to Reproduce:

  1. Create Branch protection for a branch
  2. Upload a file to the protected branch (immediately)
  3. The upload succeed

The issue is caused because graveler cache the branch protection rule results for a branch with a TTL of BranchUpdateMaxInterval=5 seconds

As this behavior is reasonable, it isn't documented anywhere.

@ItamarYuran discovered this issue 🙏

lakeFS version

1.48.2
@idanovo idanovo added bug Something isn't working docs Improvements or additions to documentation and removed bug Something isn't working labels Jan 17, 2025
@idanovo idanovo changed the title [Bug]: Branch protection rules takes effect only after 6 seconds Missing docs: Branch protection rules takes effect only after 6 seconds Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to documentation product-task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ozkatz @idanovo