Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python HL wrapper integration test uses latest published image rather than image at HEAD #8484

Open
arielshaqed opened this issue Jan 9, 2025 · 1 comment
Open

Python HL wrapper integration test uses latest published image rather than image at HEAD #8484

arielshaqed opened this issue Jan 9, 2025 · 1 comment

Comments

@arielshaqed
Copy link
Contributor

We do additionally require tests with existing versions, similar to lakeFSFS compatibility testing which we perform. But it would be very nice to test that changes to lakeFS HEAD do not break the HL wrapper.
@arielshaqed arielshaqed mentioned this issue Jan 9, 2025
Merged
@N-o-Z
Copy link
Member

N-o-Z commented Jan 9, 2025

We are using the lakeFS tag of the PR the same as all other jobs (image: ${{ needs.login-to-amazon-ecr.outputs.registry }}/lakefs:${{ needs.deploy-image.outputs.tag }}
The problem is, that we are using the latest lakefs-sdk release when we build the HL Python SDK for the tests.
We should build the lakefs-sdk as part of the test and link it when building the wrapper client

@arielshaqed arielshaqed mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@N-o-Z @arielshaqed