Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 gateway only looks at HTTP verb, not at full S3 action #7025

Closed
arielshaqed opened this issue Nov 21, 2023 · 1 comment · Fixed by #7028
Closed

S3 gateway only looks at HTTP verb, not at full S3 action #7025

arielshaqed opened this issue Nov 21, 2023 · 1 comment · Fixed by #7028
Assignees
Labels
area/gateway Changes to the gateway bug Something isn't working

Comments

@arielshaqed
Copy link
Contributor

Followup from #6930. What really happens there is that the gateway assumes only a very narrow set of S3 actions will be used, and ends up performing almost only object CRUDs.

For instance, I can call the list-object-versions API:

❯ aws s3api  list-object-versions --bucket ariels-repo  --prefix main
{
    "CommonPrefixes": [
        {
            "Prefix": "main/"
        }
    ],
    "RequestCharged": null
}

It performs exactly list-objects:

❯ aws s3api  list-objects-v2 --bucket ariels-repo  --prefix main
{
    "CommonPrefixes": [
        {
            "Prefix": "main/"
        }
    ],
    "RequestCharged": null
}

But of course lakeFS does not support S3-style object versions, and s3://ariels-repo/main is not an object on lakeFS, and it certainly does not have any versions, and this response does not follow the response syntax for this action.

@arielshaqed
Copy link
Contributor Author

Context from original issue: this comment

@nopcoder nopcoder self-assigned this Nov 22, 2023
@nopcoder nopcoder added bug Something isn't working area/gateway Changes to the gateway labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway Changes to the gateway bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants