Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow commit without a message #1395

Closed
nopcoder opened this issue Feb 2, 2021 · 5 comments · Fixed by #2927
Closed

Disallow commit without a message #1395

nopcoder opened this issue Feb 2, 2021 · 5 comments · Fixed by #2927
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nopcoder
Copy link
Contributor

nopcoder commented Feb 2, 2021

Should block at least from the CLI/UI a commit without a message

@nopcoder nopcoder added the bug Something isn't working label Feb 2, 2021
@ozkatz ozkatz added the good first issue Good for newcomers label Aug 5, 2021
@DataDavD
Copy link
Contributor

Not sure how quick I can get this done, but I'd like to take a crack at this one my PR for Issue #2190 is complete. Is that fine?

Thanks in advance.

best,
dd

@talSofer
Copy link
Contributor

talSofer commented Sep 2, 2021

Hi @DataDavD! thanks for your collaboration, we appreciate it!

@lynnro314 will be working on this issue, so unfortunately we cannot assign it to you. but please do continue commenting on issues you would want to address.

@DataDavD
Copy link
Contributor

DataDavD commented Sep 2, 2021

hey @talSofer no problem at all; thanks for the very fast (and detailed) response. I'm already assigned to 2 other issues anyways 😃

@lynnro314 lynnro314 removed their assignment Jan 9, 2022
@Jonathan-Rosenberg Jonathan-Rosenberg self-assigned this Jan 10, 2022
@Jonathan-Rosenberg
Copy link
Contributor

Hey @nopcoder and all,
Just been assigned to this issue and been wondering if there should be an enforced practice of writing meaningful commits... Although I definitely agree with this practice, other users might not.
There's a middle ground here which we can use which is adding a --allow-empty-message like flag that will state the intention of an empty commit.
What do you think?

@guy-har
Copy link
Contributor

guy-har commented Jan 10, 2022

Hey @Jonathan-Rosenberg,
I like your suggestion, I believe this is a case we should behave like git.
Supporting the --allow-empty-message sounds like a great solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants