Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change theme in Firefox #239

Closed
taramk opened this issue Jul 6, 2023 · 1 comment
Closed

Can't change theme in Firefox #239

taramk opened this issue Jul 6, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@taramk
Copy link
Contributor

taramk commented Jul 6, 2023

in Firefox, try to change the theme. when you change the selection in the dropdown, the modal closes so you can't hit save.

https://share.getcloudapp.com/z8ubOB0Z

@taramk taramk added this to the 0.6.0 milestone Jul 6, 2023
@taramk taramk added the bug Something isn't working label Jul 6, 2023
@ArcaTech
Copy link
Contributor

This is really looking like a bug in Firefox. The form uses a standard HTML dialog and doesn't have any custom behavior for displaying or closing the modal. Considering it works as expected in Safari, it seems like an issue with Mozilla's implementation.

I tried changing the form by removing method="dialog" and adding formmethod="dialog" to the Cancel button, but it still doesn't work in Firefox (but is fine in Safari).

One fix might be to redo the way form/dialog handling works (with more custom behavior instead of using the dialog element). @progrium what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants