Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design polish for table view #210

Closed
taramk opened this issue Jun 16, 2023 · 0 comments · Fixed by #233
Closed

Design polish for table view #210

taramk opened this issue Jun 16, 2023 · 0 comments · Fixed by #233
Assignees
Milestone

Comments

@taramk
Copy link
Contributor

taramk commented Jun 16, 2023

Table styles:
https://www.figma.com/file/bGzEZo0NYHhWGJO95kwF3p/Treehouse-App?type=design&node-id=311%3A4643&t=gDnarCqSzNwNgr2i-1

8px = --padding/2
4px = --padding/4

Implementation notes

  • header row on table has 8px bottom margin (on text, above horizontal rule)
  • horizontal rule below header uses --color-outline-secondary and has an 8px bottom margin, which is the same as nodes have
  • entire table has an extra 4px bottom margin (same as .expanded-node class, can consolidate these)
    remove 1px padding on header row cells
  • add "Title" header to first column (Tana does this, and it helps balance out the header row visually). header text should be aligned with node text, not node bullet.
@taramk taramk added this to the 0.5.0 milestone Jun 16, 2023
@taramk taramk mentioned this issue Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants