Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enhance GUI with tabs for all possible arguments #74

Merged
merged 10 commits into from
Nov 22, 2021

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Nov 21, 2021

This PR…

changes the graphical user interface to a tab-based design with all possible arguments

closes #70

Considerations and implementations

  • implement tab based GUI for general and advanced parameters
    • incl. adoption of event handlers
  • extract checkbox creation to be reusable and reuse
  • unify order of CLI and GUI arguments
  • move check for required input parameter (country) and reuse it

and

  • deletion of unused functions / lines of code
  • correction of eslint findings
  • refactoring

Pull Request Checklist

@treee111 treee111 changed the title Gui with tabs [FEATURE] GUI with tabs and all available arguments Nov 21, 2021
@treee111 treee111 changed the title [FEATURE] GUI with tabs and all available arguments [FEATURE] GUI with tabs and all possible arguments Nov 21, 2021
@treee111 treee111 changed the title [FEATURE] GUI with tabs and all possible arguments [FEATURE] GUI with tabs for all possible arguments Nov 21, 2021
- call each GUI-building block with Input object
- delete coloring in  Buttons class
@treee111 treee111 added the enhancement New feature or request label Nov 21, 2021
@treee111 treee111 changed the title [FEATURE] GUI with tabs for all possible arguments [FEATURE] Enhance GUI with tabs for all possible arguments Nov 22, 2021
@treee111 treee111 merged commit 243aa53 into develop Nov 22, 2021
@treee111 treee111 deleted the gui-with-tabs branch November 22, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: Add second tab for "advanced" input parameter
1 participant