Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add Dataline checks and checks for (sub-) regions #69

Merged
merged 2 commits into from
Nov 12, 2021
Merged

[FEATURE] Add Dataline checks and checks for (sub-) regions #69

merged 2 commits into from
Nov 12, 2021

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Nov 10, 2021 •
edited
Loading

This PR…

  • Adds dataline checks
  • Adds special regions check for regions not contained in the parent map
  • Adds missing if/else block while processing sub-region and parent region in geofabrik.py

Pull Request Checklist

@treee111 treee111 changed the title Dateline checks [FEATURE] Add Dataline checks and checks for (sub-) regions Nov 10, 2021
Ebe66
Ebe66 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@Ebe66 Ebe66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfectly fine to me.

@treee111 treee111 merged commit e0773c5 into develop Nov 12, 2021
@treee111 treee111 deleted the dateline-checks branch November 12, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ebe66 Ebe66 Ebe66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treee111 @Ebe66