Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Refactor downloader.py #66

Merged
merged 5 commits into from
Nov 3, 2021
Merged

[FEATURE] Refactor downloader.py #66

merged 5 commits into from
Nov 3, 2021

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Oct 31, 2021 •
edited
Loading

This PR…

mainly refactors check and download of - .osm.pbf and land_polygons - files.

extracted from #31

Considerations and implementations

In details, this PR:

  • makes check- and download function "universal" so that they can be used in multiple locations
    • move functions without self-context up
    • new functions and delete functions by moving content into other function
  • change transfer of variables / objects
    • between python script & osm_maps_functions
    • between osm_maps_functions and downloader

Pull Request Checklist

@treee111 treee111 marked this pull request as ready for review October 31, 2021 21:56
@treee111
refactor check and download of files
d9a4333 
- make check- and download function "universal"
- parts of ee874d0
@treee111
change transfer of variables / objects
25343c8 
- between python script and osm_maps_functions
- between osm_maps_functions and downloader
- all from b8dbb89
@treee111
change handling of force_processing
9e7b1f2 
- do not double-set it in init
@treee111
check changes & refactor
e35c88a 
- function created / content integrated into other function
- some comment work
@treee111
check changes & refactor 2
56c8b6e 
- move functions without self-context up
@treee111 treee111 force-pushed the refactor-downloader branch from c6a105c to 56c8b6e Compare November 3, 2021 18:40
@treee111 treee111 merged commit 4bb80a1 into develop Nov 3, 2021
@treee111 treee111 deleted the refactor-downloader branch November 3, 2021 18:54
@treee111 treee111 added the enhancement New feature or request label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@treee111