Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Update unittest files for Windows and macOS / use defined static land_polygons / refactor unittest #65

Merged
merged 5 commits into from
Oct 31, 2021

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Oct 31, 2021

This PR…

  • updates the output files to compare against for malta and liechtenstein
  • updates the static inpuf files for malta and liechtenstein
  • uses a defined set of static land_polygons files and copy to common_download prior to running tests
  • refactor test_generated_files.py
  • clarify and unify comments of test_generated_files.py and test_downloader.py

Considerations and implementations

A defined set of land_polygon files need to be used for unittests because otherwise the output will differ.
The land_polygon files are not in the repo, they are in the parent folder unittest-files

Pull Request Checklist

- malta and liechtenstein .osm.pbf files from 31.10.2021 19:50
- make function to copy files or folders to download dir
- refactor comments
- reorder functions in file
- malta and liechtenstein
  - files of unittest run on Windows
- used files
  - land_polygons.shp from 31.10.2021 19:50
  - malta and liechtenstein .osm. files from 31.10.2021 19:50
- malta and liechtenstein
  - files of unittest run on macOS
- used files
  - land_polygons.shp from 31.10.2021 19:50
  - malta and liechtenstein .osm. files from 31.10.2021 19:50
@treee111 treee111 changed the title [DEV] Update separate files for Windows and macOS for unittests / copy static land_polygons / refactor unittest [DEV] Update unittest files for Windows and macOS / use defined static land_polygons / refactor unittest Oct 31, 2021
@treee111 treee111 merged commit 8845173 into develop Oct 31, 2021
@treee111 treee111 deleted the new-files-for-unittests branch October 31, 2021 20:18
@treee111 treee111 added the infrastructure Infrastructure label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant