[DEV] refactor osm_maps_functions.py like geofabrik.py - using a interface and two implementing classes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treee111
changed the title
treee111
added a commit
that referenced
this pull request
May 5, 2023
…rface and two implementing classes (#194) refactor osm_maps_functions.py like geofabrik.py
alfh
pushed a commit
to alfh/wahooMapsCreator
that referenced
this pull request
Nov 4, 2023
…rface and two implementing classes (treee111#194) refactor osm_maps_functions.py like geofabrik.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
Considerations and implementations
aligned with https://realpython.com/python-interface/
How to test
Pull Request Checklist