-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Allow processing of multiple countries via CLI #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- XYGeofabrik class takes raw into in _init_ method - get_xy_coordinates_from_input therefore moved to geofabrik.py - unittests adopted to new way of calling XYGeofabrik class
treee111
force-pushed
the
multiple-countries
branch
from
March 30, 2023 21:22
421a3aa
to
00c18aa
Compare
treee111
changed the title
[FEAT] multiple countries
[FEAT] Allow processing of multiple countries via CLI
Apr 2, 2023
treee111
added a commit
that referenced
this pull request
May 5, 2023
* Allow input of multiple countries * move get_tiles_of_wanted_map into base class * unify xy processing with country processing - XYGeofabrik class takes raw into in _init_ method - get_xy_coordinates_from_input therefore moved to geofabrik.py - unittests adopted to new way of calling XYGeofabrik class * fix some pylint findings * Bump version to v4.0.0a1 * clarify -co and -xy cli arguments * Bump version to v4.0.0a2 * Bump version to v4.0.0a4 * enhance calc_border_countries if -nbc is given * Bump version to v4.0.0a6 * Bump version to v4.0.0a9 * calc_country_name for multiple countries
alfh
pushed a commit
to alfh/wahooMapsCreator
that referenced
this pull request
Nov 4, 2023
* Allow input of multiple countries * move get_tiles_of_wanted_map into base class * unify xy processing with country processing - XYGeofabrik class takes raw into in _init_ method - get_xy_coordinates_from_input therefore moved to geofabrik.py - unittests adopted to new way of calling XYGeofabrik class * fix some pylint findings * Bump version to v4.0.0a1 * clarify -co and -xy cli arguments * Bump version to v4.0.0a2 * Bump version to v4.0.0a4 * enhance calc_border_countries if -nbc is given * Bump version to v4.0.0a6 * Bump version to v4.0.0a9 * calc_country_name for multiple countries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
-co malta,germany,liechtenstein
Considerations and implementations
Changes in several files, doing country and X/Y in equal manner, unittests
How to test
python -m wahoomc cli -co malta,germany,liechtenstein
Pull Request Checklist