Introduce Unittests & a lot of refactoring & pylint findings corrections #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osm_maps_functions - read_process_input --> process_input and check_and_download_files file_directory_functions - read_json_file
- file- and method- comments - unused / wrong order imports - some minor other findings
osm_maps_functions - read_process_input --> process_input and check_and_download_files downloader - download_files_if_needed --> check_and_download_files_if_needed
method calc_border_countries - move from downloader --> osm_maps_functions
- for downloader.py
methods: - download_land_poligons_file - download_map
- subprocess-run-check https://vald-phoenix.github.io/pylint-errors/plerr/errors/stdlib/W1510
- create downloader later when all constructor values are known - clearer flow - constructor input parameters in lower letters
- for osm_maps_functions.py
treee111
changed the title
- delete unused path append
treee111
force-pushed
the
unit-tests-for-downloader
branch
from
acd9e48 to
4d7d59f
Compare
treee111
changed the title
treee111
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14
This PR introduces unittests for:
It also refactores a lot of mainly these two .py files and corrects pylint findings across all files