Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] handle threads as int and use f-typing to append it to cmd #147

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Sep 26, 2022

This PR…

Considerations and implementations

How to test

  1. run this branch of wahooMapsCreator for a small country on Windows 10 in VirtualBox: python -m wahoomc cli -co malta
  2. I created a alpha version, can also tested with v2.1.0a5: pip install wahoo_mc==2.1.0a5

Pull Request Checklist

  • Reviewed the Contributing Guidelines
  • Commits (and commit-messages) are understandable
  • Tested with macOS / Linux
  • Tested with Windows
  • Windows 10 in VirtualBox

@zenziwerken
Copy link
Contributor

No more error thrown. Version 2.1.0a5 works

@treee111 treee111 merged commit 3cdb75d into develop Sep 26, 2022
@treee111 treee111 deleted the fix-threads-vm branch September 26, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: can only concatenate str (not "int") to str
2 participants