[FIX] handle threads as int and use f-typing to append it to cmd #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
threads
variable consistent as integer and adds it via f-typing to the cmd command later onConsiderations and implementations
the variable
threads
was handled as string or as int depending on whether the if-statement was run throught or not.wahooMapsCreator/wahoomc/osm_maps_functions.py
Lines 646 to 648 in 1b5f89f
if handled as integer (e.g. Windows 10 running in VirtualBox), a TypeError is thrown because a integer can't be concatenated with a string this way
wahooMapsCreator/wahoomc/osm_maps_functions.py
Line 672 in 1b5f89f
How to test
python -m wahoomc cli -co malta
pip install wahoo_mc==2.1.0a5
Pull Request Checklist