[FEAT] Do not zip folders with generated files by default #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move main file to common_python folder. callable with -m - "python -m common_python cli -co malta" * rename common_python folder to wahoo_mc * move /common_resources content to /wahoo_mc/resources - incl. introducing and adjusting constants * change stuff to wahoo_mc - wahoo_maps_creator.py --> wahoo_mc - common_python --> wahoo_mc - pylint findings - adjust copy script * update documentation * move /tooling_windows content to /wahoo_mc/tooling_win - incl. adjusting constants * rename wahoo_map_creator.py to main.py
* fix pylint findings * fix last bit pylint findings --> 10/10! * adjust pylint check to need a score of 10/10 * do not check for duplicate code in test_constants and constants that is intended * install imported modules
|
merged to the wrong branch. |
treee111
added a commit
that referenced
this pull request
May 6, 2022
* disable zipping in default. provide CLI option * GUI option for zipping output folders
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
Considerations and implementations
Most of the users copy the files directly onto the device after generation and have therefore to extract the .zip files after generation. This step is not needed anymore with this PR.
How to test
Pull Request Checklist