-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Include POIs into generated maps and diplay them with VTM rendering #106
Conversation
7107e22
to
4e76129
Compare
890fd8f
to
33e98e0
Compare
I think you don't need any custom symbols in the project. They are part of the vtm library (to my understanding). https://github.com/mapsforge/vtm/tree/master/vtm-themes/resources/assets Using a @Intyre inspired snippet in my custom vtm-elemnt.xml shows up POI icons just fine in Cruiser and on the Bolt2: <m k="amenity" zoom-min="15">
<m v="cafe">
<symbol src="assets:symbols/food/cafe.svg" symbol-percent="100" />
</m>
<m v="drinking_water">
<symbol src="assets:symbols/food/drinkingtap.svg" symbol-percent="100" />
</m>
<m v="fuel">
<symbol src="assets:symbols/transport/fuel.svg" symbol-percent="100" />
</m>
</m>
<m k="shop" zoom-min="15">
<m v="bakery">
<symbol src="assets:symbols/shopping/bakery.svg" />
</m>
<m v="bicycle">
<symbol src="assets:symbols/shopping/bicycle.svg" />
</m>
<m v="supermarket">
<symbol src="assets:symbols/shopping/supermarket.svg" />
</m>
</m> |
0dd3f06
to
5ad1fa0
Compare
- docs: copy the whole vtm_theme_poi content (does not harm on e.g. BOLT)
- to check, if certain OSM tags / POIs are in the generated .map files
Added landuse forest and amenity for =fuel =cafe, shop=bicycle =bakery
- refactor and correct copyFiles script - correct cd .. statements
7138618
to
91d3f0c
Compare
Good point! I checked that on my BOLTv1. That did not work. In cruiser it also worked without having the symbols. |
1d741b2
to
b2949a7
Compare
- remaning from wahoo_mc to mahoomc was via #117
- make highways smaller on bolt (because they are black) - who drinking_water on the same zoom-level as bakeries
97f56ae
to
44c071e
Compare
…endering (#106) * initial VTM rendering theme - from https://gist.github.com/Intyre/7494d5c6c86b5bc60ce4d03b9cfce2df * copy files in - from: https://github.com/zenziwerken/Bolt2-Mapsforge-Rendertheme * write new files to the created .zip files * add docu for POI creation * move themes folder to root directory - docs: copy the whole vtm_theme_poi content (does not harm on e.g. BOLT) * scale icons to appear bigger * launch config for POIs * read out content of generated .map files - to check, if certain OSM tags / POIs are in the generated .map files * Added some tags not to be filtered. Added landuse forest and amenity for =fuel =cafe, shop=bicycle =bakery * add drinking_water POI in all relevant files * make some streets black for bolt * do not render place/locality * publish device_themes as separate .zip - refactor and correct copyFiles script - correct cd .. statements * fix unittests according to new POI constants * adjust documentation * use new symbol for drinking water - from: https://github.com/mapsforge/vtm/blob/master/vtm-themes/resources/assets/symbols/food/drinkingtap.svg * adjust launch config to correct module name - remaning from wahoo_mc to mahoomc was via #117 * vtm device theme adjustments - make highways smaller on bolt (because they are black) - who drinking_water on the same zoom-level as bakeries * adjust gitignore for osmfilter files * adjust copyFiles script * README: add POI pictures Co-authored-by: zenziwerken <[email protected]>
This PR…
Considerations and implementations
How to test
Pull Request Checklist