[BREAKING] Remove primary CLI input option -fi, that is giving a json-file with tile(s). It is replaced by #99
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the CLI input parameter across the repo - adjust unittests accordingly - delete the whole /tests/jsons folder
- remove -fi entries for .json files - delete unused entries
treee111
force-pushed
the
remove-tile-file-as-input
branch
from
8e5d2a4 to
036c99e
Compare
treee111
changed the title
-fi - json-file with tile(s)-fi - json-file with tile(s). It is replaced by #99
treee111
changed the title
-fi - json-file with tile(s). It is replaced by #99-fi, that is giving a json-file with tile(s). It is replaced by #99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
Considerations and implementations
incl.:
How to test
python wahoo_map_creator.py cli -hPull Request Checklist