Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] correct pylint findings #103

Merged
merged 4 commits into from
Apr 9, 2022
Merged

[DEV] correct pylint findings #103

merged 4 commits into from
Apr 9, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Apr 9, 2022 •
edited
Loading

This PR…

  • corrects a big amount of pylint findings

Considerations and implementations

How to test

  1. Run unittests
  2. Run GUI and process maps
  3. Process maps via CLI

Pull Request Checklist

treee111 added 4 commits April 9, 2022 12:39
@treee111
pylint config adjustments
e757800 
- lint with pylint instead of flake8

- ignore line-too-long finding

- only one "disable" line in .pylintrc
@treee111
pylint: ignore files
53a1f79
@treee111
tackle pylint findings
36c9dfe
@treee111
change run_subprocess function
dbffdd3 
- introduced with #101, commit 1f7d340
@treee111 treee111 force-pushed the tackle-pylint-findings branch from f376f16 to dbffdd3 Compare April 9, 2022 10:39
@treee111 treee111 merged commit cd8be6d into develop Apr 9, 2022
@treee111 treee111 deleted the tackle-pylint-findings branch April 9, 2022 11:22
@treee111 treee111 mentioned this pull request May 2, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@treee111