Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] restructure logging using logging-object, correct unittests & unittest-files #101

Merged
merged 7 commits into from
Apr 8, 2022
Merged

[FEATURE] restructure logging using logging-object, correct unittests & unittest-files #101

merged 7 commits into from
Apr 8, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Apr 8, 2022 •
edited
Loading

This PR…

Considerations and implementations

In addition, these things are also within this PR:

  • update / concrete conda .yml environments & renaming
  • correction of unittests
  • comitting of Windows unittest-files
  • consistent usage of #/+/! as first letter in each logging output
  • code refactoring to be consistent

How to test

  1. run wahooMapsCreator using CLI
    • check logging output

Pull Request Checklist

@treee111 treee111 added enhancement New feature or request refactoring labels Apr 8, 2022
@treee111 treee111 force-pushed the rework-logging branch 2 times, most recently from 63af25c to 78c6a52 Compare April 8, 2022 21:40
treee111 added 7 commits April 8, 2022 23:55
@treee111
refactoring: replace "print" by "log.<...>" --> logger object
effcabf 
- incl. initial setup of global logger object
@treee111
write subprocess.run() output into logging object
1f7d340
@treee111
format logged messages
7cd569a 
# ... header ...
+ sub1
+ sub2
# ... next header ...
+ sub1
+ sub2
@treee111
multiple logging adjustments
863e340 
- ----- before new "segment"
- +/#/! corrections
- f' removed
- deleted unused comments
@treee111
correct unittests
e17c617 
- map generation: accept unlimited old polygons & .osm.pbf files
- X/Y test: OS-independent path
@treee111
correct unittests test-files after updating packages
ac8b05c 
- map generation: update Windows test-files
- map generation: update macOS test-files
@treee111
adjust conda .yml files to be more concrete
9f3de55 
- by only using the conda-forge channel
@treee111 treee111 marked this pull request as ready for review April 8, 2022 21:57
@treee111 treee111 merged commit 90ea725 into develop Apr 8, 2022
@treee111 treee111 deleted the rework-logging branch April 8, 2022 21:59
@treee111 treee111 added this to the v2.0.0 milestone Apr 8, 2022
treee111 added a commit that referenced this pull request Apr 9, 2022
@treee111
change run_subprocess function
ea17220 
- introduced with: PR #101/ commit 1f7d340
treee111 added a commit that referenced this pull request Apr 9, 2022
@treee111
change run_subprocess function
f376f16 
- introduced with #101, commit 1f7d340
treee111 added a commit that referenced this pull request Apr 9, 2022
@treee111
[FEATURE] restructure logging using logging-object, correct unittests…
6026893 
… & unittest-files (#101)

changes all print outputs to log using the "global" logging object

* refactoring: replace "print" by "log.<...>" --> logger object

- incl. initial setup of global logger object

* write subprocess.run() output into logging object

* format logged messages

# ... header ...
+ sub1
+ sub2
# ... next header ...
+ sub1
+ sub2

* multiple logging adjustments

- ----- before new "segment"
- +/#/! corrections
- f' removed
- deleted unused comments

* correct unittests

- map generation: accept unlimited old polygons & .osm.pbf files
- X/Y test: OS-independent path

* correct unittests test-files after updating packages

- map generation: update Windows test-files
- map generation: update macOS test-files

* adjust conda .yml files to be more concrete

- by only using the conda-forge channel

BREAKING CHANGE:
Anaconda .yml files have now a different name for creating new environments. Existing Anaconda environments can still be used without adjustments!
treee111 added a commit that referenced this pull request Apr 9, 2022
@treee111
change run_subprocess function
dbffdd3 
- introduced with #101, commit 1f7d340
treee111 added a commit that referenced this pull request Apr 9, 2022
@treee111
[DEV] correct pylint findings (#103)
cd8be6d 
* pylint config adjustments

- lint with pylint instead of flake8

- ignore line-too-long finding

- only one "disable" line in .pylintrc

* pylint: ignore files

* tackle pylint findings

* change run_subprocess function

- introduced with #101, commit 1f7d340
@treee111 treee111 mentioned this pull request Jun 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

log using "global" logging-object instad of using print for output
1 participant
@treee111