English language fixes

[Annihilannic]

There are some English language improvements that could be made, mostly to phrases such as "Are you sure to..." (see examples below).

I'm happy to submit these changes myself, however because it is the base language it involves changing both the embedded strings in the code and all of the language files and templates.

Alternatively I could just create a new English language file. Which would be the best approach?

58,59c59,60
<   sTorrentVerification = 'Torrent verification may take a long time.' + LineEnding + 'Are you sure to start verification of torrent ''%s''?';                                                                   
<   sTorrentsVerification = 'Torrents verification may take a long time.' + LineEnding + 'Are you sure to start verification of %d torrents?';                                                                    
---
>   sTorrentVerification = 'Torrent verification may take a long time.' + LineEnding + 'Continue verification of torrent ''%s''?';                                                                                
>   sTorrentsVerification = 'Torrent verification may take a long time.' + LineEnding + 'Continue verification of %d torrents?';                                                                                  
77,78c78,79
<   sGeoIPConfirm = 'Geo IP database is needed to resolve country by IP address.' + LineEnding + 'Download this database now?';                                                                                   
<   sFlagArchiveConfirm = 'Flag images archive is needed to display country flags.' + LineEnding + 'Download this archive now?';                                                                                  
---
>   sGeoIPConfirm = 'The GeoIP database is required to resolve countries by IP address.' + LineEnding + 'Download this database now?';                                                                            
>   sFlagArchiveConfirm = 'The flag images archive is required to display country flags.' + LineEnding + 'Download this archive now?';                                                                            
87,90c88,91
<   sRemoveTorrentData = 'Are you sure to remove torrent ''%s'' and all associated DATA?';
<   sRemoveTorrentDataMulti = 'Are you sure to remove %d selected torrents and all their associated DATA?';                                                                                                       
<   sRemoveTorrent = 'Are you sure to remove torrent ''%s''?';
<   sRemoveTorrentMulti = 'Are you sure to remove %d selected torrents?';
---
>   sRemoveTorrentData = 'Confirm removal of torrent ''%s'' and all associated DATA?';
>   sRemoveTorrentDataMulti = 'Confirm removal of %d selected torrents and all their associated DATA?';
>   sRemoveTorrent = 'Confirm removal of torrent ''%s''?';
>   sRemoveTorrentMulti = 'Confirm removal of %d selected torrents?';
110c111
<   SRemoveTracker = 'Are you sure to remove tracker ''%s''?';
---
>   SRemoveTracker = 'Confirm removal of tracker ''%s''?';

[leonsoft-kras]

Too many translation files will have to be edited.
Is it better to make a file for English?

Some improvements are incomprehensible.

[Annihilannic]

Too many translation files will have to be edited.
Is it better to make a file for English?

I thought so. I have created one and submitted a pull request. It seems to have failed CI validation for unrelated reasons.

Some improvements are incomprehensible.

I'm not sure what you mean by this?

This is a summary of the suggested changes:

anni@punchbag3 lang]$ tr -d '&' <transgui.en | awk -F= '!/=.*=/&&$1!=$2{print $2}' 
English
Confirm removal of torrent '%s' and all associated DATA?
Confirm removal of torrent '%s'?
The flag images archive is required to display country flags.~Download this archive now?
The GeoIP database is required to resolve countries by IP address.~Download this database now?
Torrent verification may take a long time.~Start verification of torrent '%s'?
Confirm removal of %d selected torrents and all their associated DATA?
Confirm removal of %d selected torrents?
URL of .torrent file or magnet link
Delete .torrent file after a successful addition
Torrent verification may take a long time.~Start verification of %d torrents?
Confirm deletion of connection '%s'?
Confirm removal of tracker '%s'?
An invalid time value was entered
Torrents that are idle for N minutes aren't counted toward the Download queue or Upload queue
[anni@punchbag3 lang]$