Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show upload speed if showProgressDetails: true #766

Closed
kvz opened this issue Apr 18, 2018 · 11 comments · Fixed by #3174
Closed

Show upload speed if showProgressDetails: true #766

kvz opened this issue Apr 18, 2018 · 11 comments · Fixed by #3174

Comments

@kvz
Copy link
Member

kvz commented Apr 18, 2018

Currently it looks like this

I think it would be nice to also show kbit/s or mbit/s, etc. Reason: it's easier to diagnose if there is a component that is performing suboptimal (wether your connection, tusd, uppy-server, etc)

The speed could then also be used to render a smoother progress animation in between update events

@hpvd
Copy link

hpvd commented Apr 18, 2018

that's a nice thing! I like it. We are all technical web people. But not everyone is thinking this way. For those people using websites/platforms/tools we made, it may be to much and not understandable information (especially when dealing with different units to keep numbers of decimal cont constant). With this, depending on the audience for whom uppy is used, maybe it should be optional to show this additional information...
what do you think?

@hpvd
Copy link

hpvd commented Apr 18, 2018

edit some details in post above.
Of course having this information in background to render progress smooth is always very nice...

@hpvd
Copy link

hpvd commented Apr 18, 2018

hm not sure if "showProgressDetails: true" should be more granular to deal with this.

@kvz
Copy link
Member Author

kvz commented Apr 18, 2018

Hi @hpvd! Just to clarify, I meant to display this only when people opt-into showProgressDetails: true. By default it will be set to false and we just display % on a single 'big' line.

But when enabling details, I'd like to also render bandwidth. I've been relying on my gutfeeling so far to establish that: "hey, i think this should be faster now", so we could get some debugging done. I could imagine that if people know they have a 20mbit/s upload (but haven't worked long enough with networking to establish said gut-feeling), but see it only uploads at 300kbit/s, some might start making some noise - and then we can fix potential problems (or they can fix their connection / complain with the hotel / move their laptop to a better place, etc).

@kvz
Copy link
Member Author

kvz commented Apr 18, 2018

Yes we could consider making showProgressDetails accept an array so that you can turn on/off each individual component. And maybe we will, but we also want to focus on getting 1.0 out the door so we have bigger fish to fry, and so I'd vote to not add that complexity (right now).

But seeing the bandwidth will help us to hammer out kinks under the hood that need to be hammered out before a 1.0, so there's that :)

@hpvd
Copy link

hpvd commented Apr 18, 2018

as said I like it very much, maybe may be only to much for some usecases where typical users have no technical background...
As far as I know it's a config setting and not a thing the user himselve activates (i-symbol: "show details for my upload"), am I right?

btw: since I just used it with the uppy demo on your website:
you know the easy way of FF webtools to limit bandwidth, so one could test this function easily with having enough time without having to use large files?
2018-04-18_11h27_51

@hpvd
Copy link

hpvd commented Apr 18, 2018

off course v1.0 is far more important :-D

@hpvd
Copy link

hpvd commented Apr 18, 2018

just got a deja-vu: #65 (comment)

@kvz
Copy link
Member Author

kvz commented Apr 18, 2018

As far as I know it's a config setting and not a thing the user himselve activates (i-symbol: "show details for my upload"), am I right?

Yes it would be configured by the owner of the web/app

you know the easy way of FF webtools to limit bandwidth, so one could test this function easily with having enough time without having to use large files?

Not sure about FF, I bet it can do it. With chrome it's a dropdown in the network tab

screen shot 2018-04-18 at 13 45 58

@hpvd
Copy link

hpvd commented Apr 18, 2018

maybe one could also think about showing full details on hover on progressbar... (optional)

@arturi
Copy link
Contributor

arturi commented Jan 22, 2019

Added to backlog, closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants