Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiling subdependencies down the same way as uppy itself? #5610

Open
2 tasks done
mokutsu-coursera opened this issue Jan 17, 2025 · 0 comments
Open
2 tasks done

compiling subdependencies down the same way as uppy itself? #5610

mokutsu-coursera opened this issue Jan 17, 2025 · 0 comments
Labels

Comments

@mokutsu-coursera
Copy link
Contributor

mokutsu-coursera commented Jan 17, 2025

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

I noticed when I use @uppy/transloadit, the subdependencies p-retry and component-emitter are not compiled down, causing some compatibility issues due to nullish coalescing and optional chaining in environments where es5 is expected.

Solution

I saw that uppy itself is compiled down here https://github.com/transloadit/uppy/blob/main/babel.config.js, would it make sense for required dependencies to also targeted and compiled?

Alternatives

We're able to workaround this by targeting these 2 subdependencies for compilation in our own build scripts, but it would be nice not to have to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant