Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Drag and drop' feature does not work in I.E.11 #1622

Closed
aleccool213 opened this issue May 31, 2019 · 3 comments · Fixed by #1630
Closed

'Drag and drop' feature does not work in I.E.11 #1622

aleccool213 opened this issue May 31, 2019 · 3 comments · Fixed by #1630
Assignees
Labels

Comments

@aleccool213
Copy link

Hi there! I love this plugin! Really, great work.

Problem

  • We are using this plugin and need to support I.E. 11.
  • We need to have drag-and-drop functionality work.
  • When using this feature in I.E.11, files do not show up.

Steps to Reproduce

Screenshot at May 31 11-49-11

Visit this deploy of this codesandbox of Uppy running in 0.3.5 in I.E.11. When you drag and drop, it emits an error the console, which it emitted from this func:

module.exports = function getDroppedFiles(dataTransfer) {
  // Get all files from all subdirs. Works (at least) in Chrome, Mozilla, and Safari
  if (dataTransfer.items[0] && 'webkitGetAsEntry' in dataTransfer.items[0]) {
    return webkitGetAsEntryApi(dataTransfer);
    // Otherwise just return all first-order files
  } else {
    return fallbackApi(dataTransfer);
  }
};

I see this was introduced in version 0.4.5:

@uppy/dashboard: ⚠️ breaking: new getDroppedFiles module that is an improvement over drag-drop we’ve been using (#1440 / @lakesare)

Working version

I was able to get this feature working in I.E.11 when using version 0.3.4. Visit this deploy of this codesandbox to see it working.

@kvz
Copy link
Member

kvz commented Jun 4, 2019

Thank you so much for reporting, as well as the kind words, it means a lot! We fixed your issue, it just hasn’t been released yet, stay tuned!

@arturi
Copy link
Contributor

arturi commented Jun 12, 2019

Released on npm, please update to the latest @uppy/[email protected]!

@aleccool213
Copy link
Author

Works great! Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants