-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Create plugin for screenshots / screen recordings #1479
Comments
Related to existing closed feature #148 The difference is that today the getDisplayMedia api is now shipping in Chrome, Firefox, Edge, and is in development for Safari: https://www.chromestatus.com/feature/6744724455030784 |
Having additional Webcam modes for
seems like a good idea. I don't think the core team will have capacity to work on this soon, but PRs would be welcome (and we should be able to provide some guidance there) :) |
@arturi mentioned it probably makes more sense as a separate plugin like |
We like this idea and are hoping the community can chime in on this one, so we've marked it as |
This would be very useful feature in our app, therefore I started build a new plugin for this one. Basic concept is already functional :) |
Here is a preview of capturing screen using getDisplayMedia. |
@jukakoski thanks so much for sharing your work! looks very exciting, I’d love to see a PR and make this part of Uppy. I agree, the UI in the Webcam could be improved, and then it will be mirrored to your plugin. We could do an iteration once the functionality is in place. Please let us know if we can help in some way! |
I have took this plugin a bit further. getDisplayMedia doesn't support audio, thus I added getUserMedia stream to get audio for this plugin. Basically plugin will ask user to give access also for mic, but with this approach this plugin will be very useful tool for making educational video clips etc. Here is a capture of latest version. |
@jukakoski Sorry for the long response! The comment slipped from my radar. Sorry.
👍 I agree, it’s useful to have audio as well. Mic access is a fair tradeoff and kind of expected when you do some kind of video recording, even if it’s just the screen.
We might move it into a common component, yes. I like the concept of it, we can tweak the visual aspect just a bit to match Uppy/Webcam plugin. Now the whole team is really looking forward to your PR 💯 Thank you. |
Do you think the plugin would also support capturing a single image similar to the webcam workflow? |
@jukakoski 👋 wondering how is the progress, maybe you could send the PR already and we move the discussion there? Really looking forward to this! |
@arturi Sorry about the silence. I have been quite busy last week... |
@jukakoski its an amazing feature. How is the progress? Do you have the possibility to send PR and let the discussion going to have some sort of beta version. I would love to test it. |
@xoraingroup I haven't found to time proceed with this one. Hopefully in near future there is more time... |
Thanks @jukakoski , I will have a look at it. Cheers |
@jukakoski could you please PR your branch to Uppy, so I can tweak and merge, and you’ll be attributed properly? The invitation you sent me also expired. Sorry for the delay with this again. |
@goto-bus-stop looks like this can be closed, yes? |
yes, thanks @jrschumacher! |
It would be useful to use getDisplayMedia() from the Screen Capture API to allow users to take a screenshot of their window and upload. This would be useful for a support form, etc.
https://developer.mozilla.org/en-US/docs/Web/API/Screen_Capture_API/Using_Screen_Capture
The text was updated successfully, but these errors were encountered: