Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an icon instead of "Link" text to copy link to uploaded file #1416

Closed
nqst opened this issue Apr 5, 2019 · 1 comment · Fixed by #1574
Closed

Use an icon instead of "Link" text to copy link to uploaded file #1416

nqst opened this issue Apr 5, 2019 · 1 comment · Fixed by #1574
Labels

Comments

@nqst
Copy link
Contributor

nqst commented Apr 5, 2019

I think "Link" is not the best text for the button which performs an action (we should use verbs; but just "Copy" is incorrect and "Copy link" is too long). Also, it feels redundant when there are a lot of files:

image

I propose to use an icon instead, like this one:
Screen Shot 2019-04-05 at 12 37 55

Note: Copy icon might not work perfectly if we keep the uploading method icons (see #1412)

@kvz
Copy link
Member

kvz commented Jun 3, 2019

This issue will be closed when we merge the PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants