Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Fix missing ORDER BY statement during first incremental sync #209

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

mattsax
Copy link
Contributor

@mattsax mattsax commented Mar 17, 2023

Fix this issue : #208

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Copy link
Contributor

@Samira-El Samira-El left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@Samira-El Samira-El merged commit b418f2e into transferwise:master Mar 29, 2023
@lukeasrodgers
Copy link

@mattsax and @Samira-El thank you for the fix - this also impacted me, and resulted in a lot of head scratching. Would it be possible to cut a new version of this library?

@Samira-El
Copy link
Contributor

Hi, apologies for the late reply!

I made a new release https://pypi.org/project/pipelinewise-tap-postgres/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants