Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

feat: Keyboard support & proper labeling of things #80

Open
Freeplayg opened this issue Oct 16, 2023 · 3 comments
Open

feat: Keyboard support & proper labeling of things #80

Freeplayg opened this issue Oct 16, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Freeplayg
Copy link

Freeplayg commented Oct 16, 2023

Summary

Am not sure if this should count as a bug or feature, but having keyboard support, as well as properly labeling buttons for screen readers should be a needed thing.

I know one way most of the labeling was done in Firefish was setting the aria-label attribute in the script that adds the tooltips, so that should make that bit easier. Some cherry-picking could also probably be done for especially the form components i think? I hope I didn't make those commits too messy, I'll try to find them later
Edit: This should be the commit for the form inputs in Calckey: https://codeberg.org/firefish/firefish/commit/1cc7c3f8dd685cc0ec62d55b0bdaf32c0475735c (https://codeberg.org/firefish/firefish/pulls/10130/files)
I hope that not much has changed in misskey's input components ?

Buttons should also have an outline shown when they're focused

There's a bunch more stuff that would need to be done, but that's the most basic stuff to make it at least sort of usable. Am still learning this stuff also

@Insert5StarName Insert5StarName added the enhancement New feature or request label Oct 16, 2023
@Kio-td
Copy link

Kio-td commented Oct 16, 2023

Related: #23

@Mar0xy
Copy link
Contributor

Mar0xy commented Oct 16, 2023

"but having keyboard support" don't really what is meant with this as you can scroll using the keyboard as well as switch light/dark mode, open new post dialog

@Freeplayg
Copy link
Author

Freeplayg commented Oct 16, 2023

keyboard support as in being able to tab through every button, basic accessibility (edit: Try navigating without a mouse at all.)

There's more to it than that, i just only really know how to explain the bare minimum lol

@Insert5StarName Insert5StarName changed the title Keyboard support & proper labeling of things feat: Keyboard support & proper labeling of things Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants