Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

bug: Allow pull down to refresh on mobile #27

Closed
Kio-td opened this issue Sep 30, 2023 · 9 comments · Fixed by #123
Closed

bug: Allow pull down to refresh on mobile #27

Kio-td opened this issue Sep 30, 2023 · 9 comments · Fixed by #123
Labels
good first issue Good for newcomers

Comments

@Kio-td
Copy link

Kio-td commented Sep 30, 2023

Summary

either as a toggle, or as a default action, pulling to refresh is a fast and effective way to refresh the page, if anything goes wrong.

@Mar0xy
Copy link
Contributor

Mar0xy commented Sep 30, 2023

I wonder what happens if this line gets removed

overscroll-behavior: none;
as this line is the one that disables the reload by pulling down but I assume it would also be there for a reason

@Insert5StarName
Copy link
Contributor

remove it lets test what happens

@CutestNekoAqua
Copy link
Contributor

It should be the default to allow pulling down!

@CutestNekoAqua CutestNekoAqua added the good first issue Good for newcomers label Oct 7, 2023
@Insert5StarName Insert5StarName changed the title Allow pull down to refresh on mobile bug: Allow pull down to refresh on mobile Oct 17, 2023
@codingneko
Copy link

Any updates on this? It'd be pretty poggers to have...

@Mar0xy
Copy link
Contributor

Mar0xy commented Oct 30, 2023

It got a fix in upstream and will most likely be released next release

@codingneko
Copy link

codingneko commented Oct 30, 2023

Amazing news, thanks @Mar0xy :3

@codingneko
Copy link

codingneko commented Nov 6, 2023

Heyy, so I just wanted to let you know this implementation isn't very good imo... it only really works on the homepage, which isn't very useful because it already refreshes by default with websockets...

I would prefer this to be implemented with the default browser pull down to refresh because it would allow for refresh of any page.

There are lots of places where sharkey / misskey does not refresh correctly via webhooks, like when you're the one posting a reply from the post details view or when posting normally from the user profile view. The notification page also doesn't refresh correctly via webhooks, only the notification widget does.

In order to avoid implementing a pull down to refresh for each specific component, and fixing webhooks everywhere, I think it's MUCH easier to just let the user pull down...

@Mar0xy
Copy link
Contributor

Mar0xy commented Nov 6, 2023

I would prefer this to be implemented with the default browser pull down to refresh

This is not possible with how the client is made which is why misskey went with a custom option if you need it on every page then add the component on every page but here we are currently waiting to see what misskey themself does before doing anything else with the pull to refresh.

@codingneko
Copy link

Uh that sucks... Alright, thanks for trying at least >~<
And for the explaination!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants