From d0b00de8daae89e4ca889710ddc63f20905efc16 Mon Sep 17 00:00:00 2001 From: Reggie Riser Date: Thu, 4 Mar 2021 23:08:48 +0000 Subject: [PATCH] Syncing node version with latest version in container --- .github/workflows/analyze-bundle.yml | 4 ++-- .github/workflows/happo-tests-master.yml | 2 +- .github/workflows/happo-tests.yml | 2 +- .node-version | 2 +- .pre-commit-config.yaml | 2 +- README.md | 2 +- scripts/prereqs | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/analyze-bundle.yml b/.github/workflows/analyze-bundle.yml index fe7354aaffb..1888b7d6d5d 100644 --- a/.github/workflows/analyze-bundle.yml +++ b/.github/workflows/analyze-bundle.yml @@ -30,7 +30,7 @@ jobs: - name: Set up node uses: actions/setup-node@v1 with: - node-version: '12.16.3' + node-version: '12.21.0' - name: Install dependencies run: yarn install @@ -58,7 +58,7 @@ jobs: - name: Set up node uses: actions/setup-node@v1 with: - node-version: '12.16.3' + node-version: '12.21.0' - name: Install dependencies run: yarn install diff --git a/.github/workflows/happo-tests-master.yml b/.github/workflows/happo-tests-master.yml index 93795e93d9f..11d3a104323 100644 --- a/.github/workflows/happo-tests-master.yml +++ b/.github/workflows/happo-tests-master.yml @@ -14,7 +14,7 @@ jobs: - name: Set up node uses: actions/setup-node@v1 with: - node-version: '12.16.3' + node-version: '12.21.0' - name: Install dependencies run: yarn install diff --git a/.github/workflows/happo-tests.yml b/.github/workflows/happo-tests.yml index e8a42cbe44c..cbc35e461f4 100644 --- a/.github/workflows/happo-tests.yml +++ b/.github/workflows/happo-tests.yml @@ -31,7 +31,7 @@ jobs: - name: Set up node uses: actions/setup-node@v1 with: - node-version: '12.16.3' + node-version: '12.21.0' - name: Install dependencies run: yarn install diff --git a/.node-version b/.node-version index 493319d27c4..e68b8603836 100644 --- a/.node-version +++ b/.node-version @@ -1 +1 @@ -12.16.3 +12.21.0 diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 9acf860686d..d8617ba4397 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ default_language_version: # this should match the version in .node-version at the root of this project - node: 12.16.3 + node: 12.21.0 repos: - repo: local diff --git a/README.md b/README.md index 4b7371f7c58..f233e5b1bfb 100644 --- a/README.md +++ b/README.md @@ -258,7 +258,7 @@ You can feel free to skip running the pre-commit checks at this time. Before you #### Troubleshooting install issues (process hanging on install hooks) -Since pre-commit uses node to hook things up in both your local repo and its cache folder (located at `~/.cache/pre-commit`),it requires a global node install. If you are using nodenv to manage multiple installed nodes, you'll need to set a global version to proceed (eg `nodenv global 12.16.3`). You can find the current supported node version [here (in `.node-version`)](./.node-version). Make sure you run `nodenv install` to install the current supported version. +Since pre-commit uses node to hook things up in both your local repo and its cache folder (located at `~/.cache/pre-commit`),it requires a global node install. If you are using nodenv to manage multiple installed nodes, you'll need to set a global version to proceed (eg `nodenv global 12.21.0`). You can find the current supported node version [here (in `.node-version`)](./.node-version). Make sure you run `nodenv install` to install the current supported version. ### Setup: Dependencies diff --git a/scripts/prereqs b/scripts/prereqs index baac8aa36f7..582460745bc 100755 --- a/scripts/prereqs +++ b/scripts/prereqs @@ -61,7 +61,7 @@ has shellcheck "brew install shellcheck" has psql "brew install postgresql" has nodenv "brew install nodenv" has_path ".nodenv/shims" "nodenv init" -has node "nodenv local 12.16.3" +has node "nodenv local 12.21.0" # not on CircleCI if [[ -z ${CIRCLECI-} ]]; then