We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Affected Version: 5.7.1
When an exception is thrown somewhere down the line, the Prometheus Instrumentator removes all cause information from the Exception.
Is this a deliberate design choice or an oversight?
The middleware is implemented like this: (instrumentation.py line 168-172)
try: response = await call_next(request) status = str(response.status_code) except Exception as e: raise e from None
The from None removes information about what caused the exception.
from None
Respective python docs: https://docs.python.org/3.8/reference/simple_stmts.html#raise
The text was updated successfully, but these errors were encountered:
RuntimeError: No Reponse returned.
Successfully merging a pull request may close this issue.
Affected Version: 5.7.1
Description:
When an exception is thrown somewhere down the line, the Prometheus Instrumentator removes all cause information from the Exception.
Is this a deliberate design choice or an oversight?
Cause
The middleware is implemented like this: (instrumentation.py line 168-172)
The
from None
removes information about what caused the exception.Respective python docs: https://docs.python.org/3.8/reference/simple_stmts.html#raise
The text was updated successfully, but these errors were encountered: