Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support traits in impls #24

Closed
incertia opened this issue Jul 22, 2021 · 2 comments
Closed

support traits in impls #24

incertia opened this issue Jul 22, 2021 · 2 comments

Comments

@incertia
Copy link

test_fuzz_impl fails to correctly extract T: Trait from impl <T: Trait> Struct<T> and apply it to Args when fuzzing the impl functions. See daf5440 for some basic work trying to address this.

@smoelius
Copy link
Collaborator

This is starting to come back to me now.

Not putting the traits in Args was intentional because doing so can cause serde_derive to fail in some cases. (Related: rust-lang/rust-clippy#1689, rust-lang/api-guidelines#6)

But as recent experience shows, it's needed in some cases.

So I'm wondering what the best way to handle this is. A macro option to include the traits in Args?

@smoelius
Copy link
Collaborator

For syntax, I'm leaning toward something like:

#[test_fuzz(bound("T"))]

smoelius referenced this issue in smoelius/test-fuzz Aug 13, 2021
smoelius referenced this issue in smoelius/test-fuzz Aug 13, 2021
smoelius referenced this issue in smoelius/test-fuzz Aug 13, 2021
smoelius referenced this issue in smoelius/test-fuzz Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants