Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_providers.ec2.image is not honoured when encrypted image already exists #1528

Closed
dne opened this issue Jul 22, 2019 · 2 comments · Fixed by #1530
Closed

cloud_providers.ec2.image is not honoured when encrypted image already exists #1528

dne opened this issue Jul 22, 2019 · 2 comments · Fixed by #1530
Labels

Comments

@dne
Copy link
Contributor

dne commented Jul 22, 2019

A change of EC2 image is not respected if an existing encrypted image already exists in your AWS account.

To Reproduce

Steps to reproduce the behavior:

  1. Enable cloud_providers.ec2.encrypted
  2. Deploy Algo on EC2 with default Ubuntu image (ubuntu-disco-19.04)
  3. Change image to "ubuntu-bionic-18.04"
  4. Deploy Algo on EC2 again

Expected behavior

The first Algo instance running Ubuntu 19.04, and the second one running Ubuntu 18.04. Instead you end up with two instances running 19.04.

Proposed solution

Tag the encrypted image with the source image's name (and owner?), and add that to the filter in the "Check if the encrypted image already exist" task.

@jackivanov
Copy link
Collaborator

Thanks for reporting @dne! Can you try this PR out, please? #1530

@dne
Copy link
Contributor Author

dne commented Jul 27, 2019

Thanks for reporting @dne! Can you try this PR out, please? #1530

Really sorry for not being more helpful – currently vacationing (and using Algo of course!)…

#1530 LGTM though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants