Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added several systems-swamp + __file__ dunders #24

Closed
wants to merge 17 commits into from
Closed

Added several systems-swamp + __file__ dunders #24

wants to merge 17 commits into from

Conversation

James-Ansley
Copy link

Added dunders listed in #23 – with the exception of __traceback__, which I might come up with an example for later.

@James-Ansley James-Ansley changed the title Added seval systems-swamp + __file__ dunders Added several systems-swamp + __file__ dunders Jun 19, 2023
@trag1c trag1c linked an issue Jun 19, 2023 that may be closed by this pull request
Dunder request #23
Open
trag1c
trag1c requested changes Jun 19, 2023
View reviewed changes
Copy link
Owner

@trag1c trag1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the typehint inconsistencies across files (there are few which have typehints in some places and don't in other). From the submission guidelines:

  • Be consistent about typehints: either do them properly or don't include them at all

src/module-mesa/file/file.py Outdated Show resolved Hide resolved
src/systems-swamp/displayhook.py Outdated Show resolved Hide resolved
src/systems-swamp/stdio.py Outdated Show resolved Hide resolved
src/systems-swamp/stdio.py Outdated Show resolved Hide resolved
src/systems-swamp/stdio.py Outdated Show resolved Hide resolved
src/systems-swamp/breakpointhook.py Show resolved Hide resolved
trag1c
trag1c requested changes Jun 20, 2023
View reviewed changes
src/module-mesa/file/file.py Outdated Show resolved Hide resolved
@James-Ansley James-Ansley requested a review from trag1c June 21, 2023 04:36
@trag1c
Copy link
Owner

trag1c commented Jun 21, 2023

@James-Ansley excepthook.py and exceptions.py still apply here:

Improve the typehint inconsistencies across files (there are few which have typehints in some places and don't in other). From the submission guidelines:

  • Be consistent about typehints: either do them properly or don't include them at all

trag1c
trag1c requested changes Jun 23, 2023
View reviewed changes
Copy link
Owner

@trag1c trag1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For exceptions.py please annotate void functions with -> None

src/systems-swamp/excepthook.py Outdated


def sarcastic_excepthook(
type: Type[BaseException],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing.Type is deprecated since 3.9, just use type

qexat
qexat approved these changes Jul 26, 2024
View reviewed changes
Copy link

@qexat qexat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR alone is one video lol

@James-Ansley James-Ansley closed this by deleting the head repository Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trag1c trag1c trag1c approved these changes

@qexat qexat qexat approved these changes

Assignees
No one assigned
Labels
2 approvals missing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dunder request
3 participants
@James-Ansley @trag1c @qexat