Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setmController should be renamed setController #8

Open
apkelly opened this issue Nov 12, 2014 · 3 comments
Open

setmController should be renamed setController #8

apkelly opened this issue Nov 12, 2014 · 3 comments

Comments

@apkelly
Copy link

apkelly commented Nov 12, 2014

This may just be a personal preference, but I think the method setmController should be renamed to remove the "m".

@eeVoskos
Copy link

+1

@ksasly
Copy link

ksasly commented Dec 30, 2014

No preference, just adding that Android Studio sees "setm" and the sample MainActivity.java shows "set".

Somewhere I followed the doc that includes:
compile 'com.github.traex.calendarlistview:library:1.2.2'
so that breaks setmController / setController, omits the abstract class for date range, and app:attributes didn't work.

When I noticed the version change, I updated to calendarview 1.2.3, Android Studio wouldn't build. The new requirement is CompileSDK version 21 (I was at 19 because when 21 came out attempting to use it broke existing AS projects). This fixes the setm..., abstract class and app:attributes issues.

Hope this helps someone.

@brunocascio
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants