Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to change maxconn backend configuration from marathon labels #612

Closed
migueleliasweb opened this issue Aug 11, 2016 · 7 comments
Closed

Comments

@migueleliasweb
Copy link

migueleliasweb commented Aug 11, 2016

This is the example confif from https://docs.traefik.io/toml/

I could not find a way to change maxconn from marathon labels.

Tried:

  • traefik.backend.maxconn with value amount=1000
  • traefik.backend.(mybackendname).maxconn with value amount=1000
  • traefik.backend.maxconn.amount with value 1000

None of them worked. =/

What I did wrong ?

[Example toml from docs]

# rules
[backends]
  [backends.backend1]
    [backends.backend1.circuitbreaker]
      expression = "NetworkErrorRatio() > 0.5"
    [backends.backend1.servers.server1]
    url = "http://172.17.0.2:80"
    weight = 10
    [backends.backend1.servers.server2]
    url = "http://172.17.0.3:80"
    weight = 1
  [backends.backend2]
    [backends.backend1.maxconn]
      amount = 10
      extractorfunc = "request.host"
@jangie
Copy link
Contributor

jangie commented Aug 13, 2016

It appears that Traefik isn't yet reading any labels to set maxconn values (see: template, provider code.) I'll take a stab at this.

@migueleliasweb
Copy link
Author

I think the same happens on some other labels. I compared marathon provider with the file provider and seems to me that some other configurations are missing...

Anyway, thanks @jangie !

@jangie
Copy link
Contributor

jangie commented Aug 15, 2016

Yeah, aside from maxconn, it appears that circuit breaker and which specific loadbalancer algorithm are the two missing currently from the marathon provider's Backend configurability. I plan on adding those in soon, perhaps in the existing PR I have for maxconn.

@migueleliasweb
Copy link
Author

migueleliasweb commented Aug 15, 2016

🎉 Perfect ! That would help a lot !

Ps(edit): I actually know Go but I could not help much with this issue because I had a lot of trouble trying to create a development environment for Traefik. Maybe some docs to help with build would make more people help directly with PRs !

@jangie
Copy link
Contributor

jangie commented Aug 15, 2016

yeah... this past weekend was honestly my first stab at playing with go or with traefik's code and i had some trouble getting myself setup. i'm not even entirely sure i'm setup fully at this point (ha) but i was at least able to test that maxconn is settable via labels in my fork and will be able to do likewise for the other items. if i get some time maybe i'll try setting up from scratch and take notes.

@emilevauge
Copy link
Member

@migueleliasweb you can get documentation for contributing on the front page https://github.com/containous/traefik#contributing ;)

@ldez ldez added the kind/question a question label Apr 12, 2017
@timoreimann
Copy link
Contributor

The branch got merged, so closing.

@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants