-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not able to change maxconn backend configuration from marathon labels #612
Comments
It appears that Traefik isn't yet reading any labels to set maxconn values (see: template, provider code.) I'll take a stab at this. |
I think the same happens on some other labels. I compared marathon provider with the file provider and seems to me that some other configurations are missing... Anyway, thanks @jangie ! |
Yeah, aside from maxconn, it appears that circuit breaker and which specific loadbalancer algorithm are the two missing currently from the marathon provider's Backend configurability. I plan on adding those in soon, perhaps in the existing PR I have for maxconn. |
🎉 Perfect ! That would help a lot ! Ps(edit): I actually know Go but I could not help much with this issue because I had a lot of trouble trying to create a development environment for Traefik. Maybe some docs to help with build would make more people help directly with PRs ! |
yeah... this past weekend was honestly my first stab at playing with go or with traefik's code and i had some trouble getting myself setup. i'm not even entirely sure i'm setup fully at this point (ha) but i was at least able to test that maxconn is settable via labels in my fork and will be able to do likewise for the other items. if i get some time maybe i'll try setting up from scratch and take notes. |
@migueleliasweb you can get documentation for contributing on the front page https://github.com/containous/traefik#contributing ;) |
The branch got merged, so closing. |
This is the example confif from https://docs.traefik.io/toml/
I could not find a way to change maxconn from marathon labels.
Tried:
None of them worked. =/
What I did wrong ?
[Example toml from docs]
The text was updated successfully, but these errors were encountered: