Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels might be cut off when disabling scale and scroll #947

Closed
maxbethke opened this issue Dec 20, 2021 · 7 comments · Fixed by #976
Closed

Labels might be cut off when disabling scale and scroll #947

maxbethke opened this issue Dec 20, 2021 · 7 comments · Fixed by #976
Assignees
Labels
enhancement Feature requests, and general improvements.
Milestone

Comments

@maxbethke
Copy link

Lightweight Charts Version: 3.7.0

Steps/code to reproduce: refer to this codesandbox https://codesandbox.io/s/unruffled-benz-z9f5p

Actual behavior: The last label on the time axis will be hidden behind a non-transparent canvas, if it happens to overflow the canvas for the time scale

Expected behavior: The time scale labels would be overflowing their canvas, so they would display their whole content

Screenshots:

CodeSandbox/JSFiddle/etc link: https://codesandbox.io/s/unruffled-benz-z9f5p

With reference to
#226 and #835

@maxbethke maxbethke changed the title Labels might be cut off when disbaleing scale and scroll Labels might be cut off when disabling scale and scroll Dec 20, 2021
@maxbethke
Copy link
Author

This can happen on the left end of the time scale too btw
grafik

@timocov timocov added enhancement Feature requests, and general improvements. good first issue Good issue for first-time contributors. labels Dec 29, 2021
@timocov timocov added this to the 3.8 milestone Dec 29, 2021
@timocov
Copy link
Contributor

timocov commented Dec 29, 2021

The fix should be somewhere here - we need to respect disabling scrolling/scaling as well, not just fixing an edge.

@timocov timocov added the help wanted Asking for outside help and/or contributions to this particular issue or PR. label Dec 29, 2021
@timocov
Copy link
Contributor

timocov commented Dec 29, 2021

@maxbethke would you like to create a fix for this?

@rchvalbo
Copy link

Would a fix for this solve the issue with series markers being cutoff? This issue has been haunting us for quite some time. No work around for it at the moment. We just need the ability to shift these markers in. Maybe an ability to add left/right padding for any marker plotting? Let me know if there's something I can do to help. We really need this.
image

@timocov
Copy link
Contributor

timocov commented Dec 30, 2021

@rchvalbo no, I don't think so. Please create another ticket for that.

@timocov timocov removed help wanted Asking for outside help and/or contributions to this particular issue or PR. good first issue Good issue for first-time contributors. labels Jan 14, 2022
@maxbethke
Copy link
Author

maxbethke commented Jan 17, 2022

@maxbethke would you like to create a fix for this?

Sorry, gotcha too late. Would have loved to help. @timocov

@timocov
Copy link
Contributor

timocov commented Jan 17, 2022

@maxbethke no worries, we handled it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests, and general improvements.
Projects
None yet
4 participants