Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log axis is not scaling on small number #874

Closed
thanhlmm opened this issue Oct 18, 2021 · 5 comments · Fixed by #930
Closed

Log axis is not scaling on small number #874

thanhlmm opened this issue Oct 18, 2021 · 5 comments · Fixed by #930
Assignees
Labels
bug Unexpected problem or unintended behavior.
Milestone

Comments

@thanhlmm
Copy link

thanhlmm commented Oct 18, 2021

Lightweight Charts Version: Latest

Steps/code to reproduce:
Use log axis in small number, About 0 - 0.0003

Actual behavior:

Screen.Recording.2021-10-18.at.9.24.47.AM.mov

Expected behavior:

Highchart can scale on very small number like the video

Screenshots:

Screen Shot 2021-10-18 at 9 27 30 AM

image

Log chart on lightweight-charts vs highchart

CodeSandbox/JSFiddle/etc link:

@timocov timocov added the needs investigation Needs further investigation. label Oct 19, 2021
@timocov
Copy link
Contributor

timocov commented Oct 19, 2021

Probably the issue with this constants, but needs to investigate.

@timocov timocov added this to the 4.0 milestone Oct 19, 2021
@thanhlmm
Copy link
Author

const enum Constants {
	LogicalOffset = 10,
	CoordOffset = 0.0000001,
}

Screen Shot 2021-10-20 at 2 31 38 PM

This is the result after I changed the Constants, which is work for me and does not affect other charts whose price is various.

@timocov is it worse to create MR which this config?

@timocov
Copy link
Contributor

timocov commented Oct 20, 2021

@eugene-korobko any thoughts?

@timocov
Copy link
Contributor

timocov commented Oct 20, 2021

@thanhlmm I discussed the issue with @eugene-korobko internally. We're preparing fix for log scale for tradingview.com and after the fix is ready we'll merge it to lightweight-charts as well. It's a bit more complex than just change constants, so lets leave this for us.

@timocov timocov added bug Unexpected problem or unintended behavior. and removed needs investigation Needs further investigation. labels Oct 20, 2021
@thanhlmm
Copy link
Author

Sound good to me

@timocov timocov modified the milestones: 4.0, 3.8 Nov 19, 2021
@timocov timocov assigned timocov and unassigned eugene-korobko Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants