Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribeClick on mobile always get the last index of all the items #657

Closed
ArcherDs opened this issue Dec 20, 2020 · 2 comments · Fixed by #972
Closed

subscribeClick on mobile always get the last index of all the items #657

ArcherDs opened this issue Dec 20, 2020 · 2 comments · Fixed by #972
Assignees
Labels
bug Unexpected problem or unintended behavior.
Milestone

Comments

@ArcherDs
Copy link

ArcherDs commented Dec 20, 2020

Lightweight Charts Version: 3.2.0

On desktop ,the behavior is perfect
On mobile , the param always receive the last index item

https://codesandbox.io/s/blissful-cloud-mucwc?file=/src/index.js

Open result in new window and use browser's mobile mode can reproduce the problem

#539

@timocov
Copy link
Contributor

timocov commented Dec 21, 2020

That's because on touch devices there is "Tracking mode" - you need to long press first to activate crosshair and then you can move crosshair to select a bar.

But I agree that it looks like a bug actually, perhaps we don't need to fire that click event when no tracking mode is active.

Related to #106.

@timocov timocov added the bug Unexpected problem or unintended behavior. label Dec 21, 2020
@timocov timocov added this to the 4.0 milestone Dec 21, 2020
@timocov timocov modified the milestones: 4.0, 3.8 Jan 21, 2022
@timocov
Copy link
Contributor

timocov commented Jan 21, 2022

Fixed in #972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants