Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to give a single line serie multiple colors with Tradingview Lightweight charts in Javascript? #412

Closed
allartdo opened this issue Apr 22, 2020 · 6 comments

Comments

@allartdo
Copy link

I think it should be a common thing to change the color of a line series for each new created part of a line. This url explains my issue.
https://stackoverflow.com/questions/61349463/how-to-give-a-single-line-serie-multiple-colors-with-tradingview-lightweight-cha

Im kinda new to this github issue reports, please explain if I do something wrong.

@timocov
Copy link
Contributor

timocov commented Apr 22, 2020

Duplicate of #195

@timocov timocov marked this as a duplicate of #195 Apr 22, 2020
@timocov timocov closed this as completed Apr 22, 2020
@allartdo
Copy link
Author

So if I understand correctly, you want me or someone else to dive into your code and fix the not dynamic code? I did this to get the price of the last added line... In 3 hours. I would need 50 euro per hour to do that for customers... Sorry if im wrong ¯_(ツ)_/¯

@timocov
Copy link
Contributor

timocov commented Apr 22, 2020

It's open source, if you'd like to add this feature asap, you can do it yourself and provide PR with fixes (but before that we need to get proposal first in the original issue). If you don't want to/can't fix it, you can subscribe to original issue and wait until it'll be closed so that means it's fixed.

@allartdo
Copy link
Author

Alright, I probably change library since this isn't my only problem. I will give you some critical feedback why I get kinda triggered because of the Lightweight chart library:

Documentation is kinda hard to follow. Its diffrent then the usuall documentation like, chart.js, leaflet etc. It took for me a lot of time to find out how to get to all parts of the documentation because if I follow the /docs/readme I see only 3 extra links to move to any after, provide a list with all documentation pages and u already make it much better. For beginners it might take infinate now and experts may not even start using this.

While using the library it feels like there are just missing parts, getPrice(), getMarkers, setMarker (instead of setMarkers), removeMarker(), removeAllMarkers() etc. etc... I understand this is open source and you need to program most of it by urself but these functions seem pritty much standard, in a library like this, for me.

If I look at the #195 link you send and see that that guy posted last year september and again another guy did in februari and ended in march and now me with still no answer/commit or at least pseudo code, I would say you must find a real fan of your library to get it fixed. So your last answer feels pritty much a useless/duplicate and a "politic correct" answer if u understand what im saying. My answer would be (example without actuall fact of u or ur team): Yes allartdo, since we are not planned to fix this and our goal doesn't lies here, you really have to build this in urself or have to wait untill someone else does. If you do want to try and fix it you might want to look in this or these file('s). This might shorten your time searching for the correct files. Also these function may help you solve your problem: ...

I hope you understand what im trying to do, I make sure I dont need to program it myself but give the complaining guy with an issue a big advantage to actually make it himself. Just like in an shop, the customer wants a mars chocelate bar but since the shop doesn't have it the shop say's sorry we dont have it and offers a kitkat chocelate bar. This to make the end result of the customer hopefully happy (and get more money). Again both parties end up with a bigger change of being happy.

As I said in the beginning of my question, I posted this question on stackoverflow (and other questions about the library) and it seems there are not that many people using the library in Javascript. This is, ofcourse, not a fact but a feeling I get, which could be wrong.

If I read the first lines in the readme here: https://github.com/tradingview/lightweight-charts then it seems to me that you focus mostly on performance and speed. I understand you dont want to have a chart that laggs, but with the new tech today and very strong processors you would need to really fk up ur code to make it this laggy. If your pc or device is so bad that it can't handle the chart it must be a pc of at least 10 years old in my opinion. I would say if my goal would be userbility to defeat library's like Chart.js. Since tradingview.com is one of the most used charting viewers to quikly edit data. Example of userbility: Be able to simply rebuild one of your (in web) made charts to a programmed chart. This is, in my opinion, again very basic stuff.

Again my intention is not to break a hart but to make it stronger, I give feedback which may be hard but nice to have.
https://www.google.com/search?q=feedback+quote&sxsrf=ALeKk03_-jy2bp_6XgeT26HewGWmMclrMA:1587561885840&source=lnms&tbm=isch&sa=X&ved=2ahUKEwiNtY7ykPzoAhWP5KQKHc_fA5QQ_AUoAXoECA0QAw&biw=1920&bih=937

Use it in advance :)

@timocov
Copy link
Contributor

timocov commented Apr 22, 2020

@allartdo may I ask you to copy that feedback to #362 please? We collect all feedback there and I think it's good candidate to be there.

@allartdo
Copy link
Author

I will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants