Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkFit for TBB v2021.1.1 compatibility #290

Closed
mrodozov opened this issue Jan 14, 2021 · 2 comments
Closed

Update mkFit for TBB v2021.1.1 compatibility #290

mrodozov opened this issue Jan 14, 2021 · 2 comments

Comments

@mrodozov
Copy link

Dear devs,

we are trying to have tbb v2021.1.1 integrated for CMS externals and currently building mkFit is failing
with:
make: *** No rule to make target 'tbb/task_scheduler_init.h', needed by 'main.o'. Stop.
which I cannot say this is limited to (I mean only this is missing)
ROOT are having the same issue, so they might already have a solution (haven't checked yet)
I'd like to ask if you could update mkFit for the new tbb version.
There is this deprecation document and the substitutes for the old api:
https://software.intel.com/sites/default/files/managed/b2/d2/TBBRevamp.pdf

Thank you in advance,
Cheers,
Mircho

@dan131riley
Copy link
Collaborator

@mrodozov I fixed the TBB deprecations on the devel branch in #286 by mostly copying what Chris did for CMSSW. Just submitted PR #291 with the backport to the release branch.

@mrodozov
Copy link
Author

very nice :) closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants