From acaa2f53667dabe417b60c854bb61c0a8fe1d9e5 Mon Sep 17 00:00:00 2001 From: Claudio Agosti Date: Fri, 26 May 2017 23:57:30 +0200 Subject: [PATCH 1/3] some UX suggestion apply --- src/components/visualFeedback.js | 16 +++++++++------- styles/app.scss | 2 +- styles/visualFeedback.scss | 18 ++++++++++-------- 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/components/visualFeedback.js b/src/components/visualFeedback.js index 9fcb4e4..d10a4d3 100644 --- a/src/components/visualFeedback.js +++ b/src/components/visualFeedback.js @@ -11,27 +11,29 @@ const VisualFeedback = React.createClass({ var message; const actionLink = `https://facebook.tracking.exposed/realitycheck/${config.userId}/data`; - const actionText = '⦑ Last activities ⦒'; + const actionText = 'Your data'; if (isPublic) { badge = '✔'; message = 'This post has been recorded'; } else { badge = '⛔️'; - message = 'The content of this post will be kept private.'; + message = 'This post will be kept private'; } return (
-

- - facebook.tracking.exposed -

{badge} - {message} {actionText} + {message} + + + + + + {actionText}
); diff --git a/styles/app.scss b/styles/app.scss index b389d9e..808ba65 100644 --- a/styles/app.scss +++ b/styles/app.scss @@ -5,5 +5,5 @@ @import 'visualDebug'; div[role="banner"] { - background-color: green !important; + background-color: #93c993 !important; } diff --git a/styles/visualFeedback.scss b/styles/visualFeedback.scss index 9b5f9ec..b5613d7 100644 --- a/styles/visualFeedback.scss +++ b/styles/visualFeedback.scss @@ -3,21 +3,23 @@ padding: 6px 12px; background-color: #f6f7f9; - h1 { - img { - vertical-align: middle; - margin: 0 4px 2px 0; - } - - margin-bottom: 10px + img { + vertical-align: middle; + margin: 0 4px 2px 0; } .fbtrex--badge { color: red; - margin-right: 6px; + margin-left: 6px; } .fbtrex--message { + margin-left: 10px; + margin-right: 10px; + } + + .fbtrex--logo { + margin-left: 40px; } &.fbtrex--less-info { From d4b31c4a14008307afd86d8732590a82183588d6 Mon Sep 17 00:00:00 2001 From: Claudio Agosti Date: Sat, 27 May 2017 00:17:51 +0200 Subject: [PATCH 2/3] removed all Tabs privileges --- manifest.json | 1 - src/chrome/popup/components/settings.js | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/manifest.json b/manifest.json index 1bcd36b..b029e04 100644 --- a/manifest.json +++ b/manifest.json @@ -18,7 +18,6 @@ }, "permissions": [ - "tabs", "storage", "cookies", "http://localhost:8000/", diff --git a/src/chrome/popup/components/settings.js b/src/chrome/popup/components/settings.js index c96c8e0..62c0721 100644 --- a/src/chrome/popup/components/settings.js +++ b/src/chrome/popup/components/settings.js @@ -32,8 +32,9 @@ export default class Settings extends React.Component { settings: {$set: settings}, reloadBrowser: {$set: true}}))); - chrome.tabs.query({url: 'https://*.facebook.com/*'}, - tabs => tabs.forEach(tab => chrome.tabs.reload(tab.id))); + chrome.tabs.reload(); + /* chrome.tabs.query({url: 'https://*.facebook.com/*'}, + tabs => tabs.forEach(tab => chrome.tabs.reload(tab.id))); */ } resetSettings () { From b9e2a5851cc0241dc421bd1f692d9ebbf3c3d5ab Mon Sep 17 00:00:00 2001 From: Claudio Agosti Date: Sat, 27 May 2017 00:18:18 +0200 Subject: [PATCH 3/3] implemented some UX improvement suggestions --- src/chrome/popup/components/infoBox.js | 4 ++-- src/components/onboardingBox.js | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/chrome/popup/components/infoBox.js b/src/chrome/popup/components/infoBox.js index 176c0e4..bec74d6 100644 --- a/src/chrome/popup/components/infoBox.js +++ b/src/chrome/popup/components/infoBox.js @@ -41,8 +41,8 @@ const InfoBox = React.createClass({ free, open source code everyone can audit.
  • - Here you have - your data, available to be downloaded or consulted (is a work in progress!). It contains what Facebook is showing you. In the 2017 will be improved with new visualizations and will become private. + Access to + your data, available to be downloaded or consulted (is a work in progress!). It contains what Facebook is showing you. In the 2017 will be improved with new visualizations and functionalities.
    • diff --git a/src/components/onboardingBox.js b/src/components/onboardingBox.js index c5d81d0..7ccbdf0 100644 --- a/src/components/onboardingBox.js +++ b/src/components/onboardingBox.js @@ -9,7 +9,7 @@ const OnboardingBox = React.createClass({

    Yay!! Welcome to facebook.tracking.exposed!

    -

    This is awesome, thanks for contributing. One last thing before we start. We need you to post your public key, so we can associate it with your contributions. Copy and paste the following message as new public post:

    +

    We need you to post your public key, copy and paste the following message as new public post. After a minute you an safely delete it.

    Personalisation Algorithms are a collective issue, and can only be collectively addressed; today I am joining @@ -17,16 +17,16 @@ const OnboardingBox = React.createClass({ this message is necessary to link my account to the following key: {publicKey}

    - If you do not want to show this message on your wall for whatever reason, we understand; just wait a minute and then you can safely delete it. After we retrieve your key this box will disappear. + We need you to post this key so we can associate it with yout contributions. After you post the key above, this post will disappear. If something does not work, contact us on our facebook page or open an issue on github.

    - +

    - facebook.tracking.exposed onboarding is not completed yet. + facebook.tracking.exposed onboarding is not completed yet.
    );