-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request too large!! #58
Comments
I would suggest, that instead of sending data in batches, we split them. To keep it simple, send each impression as a different request. |
Yes split them looks like the simplest way to avoid this issue. but send each impression as a different request would mean change the internal structure of the extension, it is too much. We have setup an internal timeout in the extension, https://github.com/tracking-exposed/web-extension/blob/master/webpack.config.js#L44 (in this line, when is development is 10seconds, default is 20 seconds delay) The timing can be reduced to 5 seconds in production perhaps and this would cause, in 5 seconds, facebook do not provide you more than 6-8 post top.. |
as context: each post might contain up to 30kbytes, and before the limit was set to 1mb. In certain condition (large monitor, large performance) the threshold of 1mb get reach and so I extend it to 3mb (now are 4mb) 8421e79 |
We can add a size boundary in the client, so it flushes if a timeout is reached or a specific size is reached. |
loading many posts at one reach the server limit of 3Mb
The text was updated successfully, but these errors were encountered: