Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: types and type tests #23

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Jan 27, 2021

Fixes #38. Needs a rebase!

@mamiller93
Copy link

@chriskrycho how can I help to get this finished? I started defining the types locally to be able to use this in my own codebase.

@chriskrycho
Copy link
Contributor Author

@mamiller93 a few steps:

  1. Add the rest of the type definitions. (I don't remember which those are off the top of my head, but you can compare from the types vs. the public API.)
  2. Use expect-type alongside the runtime tests to validate the expected interface. Note: prefer the .toEqualTypeOf matcher; do not use the .toMatchTypeOf. The former will blow up if we accidentally widen (e.g. to accidentally start returning any somewhere), the latter will let it pass.

That should do it. Feel free to open a PR against this PR with that set of changes! Note that I may be slower to respond, however, as I'm on vacation until Aug. 2.

@esbanarango
Copy link

🙏

@basz
Copy link

basz commented Oct 28, 2022

Friendly reminder this is still open... Something blocking? Would love to use TS.

@RobbieTheWagner
Copy link

Anyone interested in pushing this over the finish line?

@chriskrycho
Copy link
Contributor Author

I'm going to push it over the finish line either in the next two weeks (if I get Ember's core types published!) or in mid-January if no one beats me to it. It's simple and easy, though, so someone should beat me to it. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Support
5 participants