From 269a14c88b9bdf9bae36c2e75b89c58c4b421000 Mon Sep 17 00:00:00 2001 From: Chris Krycho Date: Fri, 3 Sep 2021 19:33:49 -0600 Subject: [PATCH 1/4] Chore: only run ember-try suite *once* --- .github/workflows/CI.yml | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index bb005afb..0a8e5e04 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -36,7 +36,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - run: yarn install --frozen-lockfile --non-interactive - - run: yarn test + - run: ./node_modules/.bin/ember test tests_other: needs: lint @@ -51,7 +51,24 @@ jobs: - uses: actions/checkout@v2 - uses: volta-cli/action@v1 - run: yarn install --frozen-lockfile --non-interactive - - run: yarn test + - run: ./node_modules/.bin/ember test + + tests_compat: + needs: tests_linux + name: "Tests: Ember compatibility (ember-source@${{ matrix.node-version }})" + runs-on: ubuntu-latest + strategy: + matrix: + ember-version: + ["lts-3.16", "lts-3.20", "lts-24", "release", "beta", "canary"] + + steps: + - uses: actions/checkout@v2 + - uses: volta-cli/action@v1 + with: + node-version: ${{ matrix.node-version }} + - run: yarn install --frozen-lockfile --non-interactive + - run: "./node_modules/.bin/ember try:one ember-${{ matrix.ember-version }}" tests_ts: needs: lint From cac18cae1035d9c23290b771f29ea7f48136b31d Mon Sep 17 00:00:00 2001 From: Chris Krycho Date: Fri, 3 Sep 2021 19:40:39 -0600 Subject: [PATCH 2/4] Fix name of ember-compat runs --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 0a8e5e04..4e7ab62c 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -55,7 +55,7 @@ jobs: tests_compat: needs: tests_linux - name: "Tests: Ember compatibility (ember-source@${{ matrix.node-version }})" + name: "Tests: Ember compatibility (ember-source@${{ matrix.ember-version }})" runs-on: ubuntu-latest strategy: matrix: From 726f934bb4660d0a3e52ef19c8785bd770b2b633 Mon Sep 17 00:00:00 2001 From: Chris Krycho Date: Fri, 3 Sep 2021 19:41:37 -0600 Subject: [PATCH 3/4] Allow beta and canary to fail (for now) --- config/ember-try.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config/ember-try.js b/config/ember-try.js index 345d5d30..f7f02d75 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -46,6 +46,7 @@ module.exports = async function () { }, { name: "ember-beta", + allowedToFail: true, npm: { devDependencies: { "ember-source": await getChannelURL("beta"), @@ -54,6 +55,7 @@ module.exports = async function () { }, { name: "ember-canary", + allowedToFail: true, npm: { devDependencies: { "ember-source": await getChannelURL("canary"), From cb1f4813f1ee31114c11cf6f2e1ce00e364b6a91 Mon Sep 17 00:00:00 2001 From: Chris Krycho Date: Fri, 3 Sep 2021 19:46:16 -0600 Subject: [PATCH 4/4] Fix name of 3.24 LTS ember-try job --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4e7ab62c..01bdf75c 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -60,7 +60,7 @@ jobs: strategy: matrix: ember-version: - ["lts-3.16", "lts-3.20", "lts-24", "release", "beta", "canary"] + ["lts-3.16", "lts-3.20", "lts-3.24", "release", "beta", "canary"] steps: - uses: actions/checkout@v2