From 7292955494d6933820226d39c59c87ec5dd1132d Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Tue, 29 Oct 2024 22:52:09 +0100 Subject: [PATCH] test: remove unneeded listeners Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: https://github.com/nodejs/node/pull/55486 Reviewed-By: Jake Yuesong Li --- test/parallel/test-child-process-dgram-reuseport.js | 2 +- test/parallel/test-child-process-net-reuseport.js | 2 +- test/parallel/test-cluster-dgram-reuseport.js | 4 ++-- test/parallel/test-cluster-net-reuseport.js | 3 --- test/parallel/test-dgram-reuseport.js | 2 -- test/parallel/test-net-reuseport.js | 2 -- 6 files changed, 4 insertions(+), 11 deletions(-) diff --git a/test/parallel/test-child-process-dgram-reuseport.js b/test/parallel/test-child-process-dgram-reuseport.js index 30f04640f6f570..4eea13c525bcb8 100644 --- a/test/parallel/test-child-process-dgram-reuseport.js +++ b/test/parallel/test-child-process-dgram-reuseport.js @@ -32,4 +32,4 @@ const socket = dgram.createSocket(options); socket.bind(+process.env.port, common.mustCall(() => { socket.close(); -})).on('error', common.mustNotCall()); +})); diff --git a/test/parallel/test-child-process-net-reuseport.js b/test/parallel/test-child-process-net-reuseport.js index 575977fc4168ed..52309edd1b3be1 100644 --- a/test/parallel/test-child-process-net-reuseport.js +++ b/test/parallel/test-child-process-net-reuseport.js @@ -32,4 +32,4 @@ const server = net.createServer(); server.listen({ ...options, port: +process.env.port }, common.mustCall(() => { server.close(); -})).on('error', common.mustNotCall()); +})); diff --git a/test/parallel/test-cluster-dgram-reuseport.js b/test/parallel/test-cluster-dgram-reuseport.js index f859721f5d7c76..da7a90337c8ff7 100644 --- a/test/parallel/test-cluster-dgram-reuseport.js +++ b/test/parallel/test-cluster-dgram-reuseport.js @@ -35,5 +35,5 @@ socket1.bind(0, () => { socket2.bind(socket1.address().port, () => { socket1.close(close); socket2.close(close); - }).on('error', common.mustNotCall()); -}).on('error', common.mustNotCall()); + }); +}); diff --git a/test/parallel/test-cluster-net-reuseport.js b/test/parallel/test-cluster-net-reuseport.js index 985bb2193f2c05..b875490d61fab9 100644 --- a/test/parallel/test-cluster-net-reuseport.js +++ b/test/parallel/test-cluster-net-reuseport.js @@ -36,6 +36,3 @@ server1.listen(options, common.mustCall(() => { server2.close(close); })); })); - -server1.on('error', common.mustNotCall()); -server2.on('error', common.mustNotCall()); diff --git a/test/parallel/test-dgram-reuseport.js b/test/parallel/test-dgram-reuseport.js index c9b6f7964ab666..e5fd6965818d4c 100644 --- a/test/parallel/test-dgram-reuseport.js +++ b/test/parallel/test-dgram-reuseport.js @@ -12,8 +12,6 @@ function test() { socket2.close(); })); })); - socket1.on('error', common.mustNotCall()); - socket2.on('error', common.mustNotCall()); } checkSupportReusePort().then(test, () => { diff --git a/test/parallel/test-net-reuseport.js b/test/parallel/test-net-reuseport.js index f04db09d04a99a..3b7fc100be7ddd 100644 --- a/test/parallel/test-net-reuseport.js +++ b/test/parallel/test-net-reuseport.js @@ -13,8 +13,6 @@ function test(host) { server2.close(); })); })); - server1.on('error', common.mustNotCall()); - server2.on('error', common.mustNotCall()); } checkSupportReusePort()