Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Improve basic documentation in description #8

Open
merwok opened this issue Jan 5, 2017 · 4 comments
Open

Improve basic documentation in description #8

merwok opened this issue Jan 5, 2017 · 4 comments

Comments

@merwok
Copy link

merwok commented Jan 5, 2017

Hello! I found this plugin when looking for doc about Python / tox usage in CircleCI. The current doc doesn’t explain clearly what problem it solves, and my tox config that doesn’t use it seems to work.

@stavxyz
Copy link
Collaborator

stavxyz commented Jan 5, 2017

@stavxyz
Copy link
Collaborator

stavxyz commented Jan 5, 2017

The documentation here definitely needs updating though, thanks for pointing this out.

@merwok
Copy link
Author

merwok commented Jan 5, 2017

The second link is helpful, thanks! I am using the pyenv local trick in my config, but I haven’t confirmed yet that the right versions are picked up.

@stavxyz
Copy link
Collaborator

stavxyz commented Jan 5, 2017

Yeah, you might want to assert that the exact python version you expect to be running is in fact running your tests. In fact, it was only when I added these assertions and they started failing when when I got worried and was motivated to write this plugin. The very tests for this plugin itself do exactly this (assert the exact version) as part of the test suite for tox-pyenv. See the environment variables set as TOX_*:

https://github.com/samstav/tox-pyenv/blob/master/circle.yml

Then passed through via tox config:

https://github.com/samstav/tox-pyenv/blob/master/tox.ini#L8

and the python version is asserted to be exactly as it is set during the test:

https://github.com/samstav/tox-pyenv/blob/master/test_tox_pyenv.py#L30-L52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants