Fix clippy warnings #505
Merged
Fix clippy warnings #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Jan 4, 2021
hawkw
approved these changes
Jan 4, 2021
|
One other note: if we're going to start caring about clippy lints (which I think we ought to), I think we should probably add a Clippy check step on CI. This will stop us from going and adding new code that clippy doesn't like, and having to do another big "fix clippy warnings" PR to make them go away. We can do that separately, though. |
hawkw
approved these changes
Jan 4, 2021
olix0r
reviewed
Jan 4, 2021
tower/src/balance/p2c/service.rs
Outdated
|
|
||
| /// Returns whether or not the balancer is empty. | ||
| pub fn is_empty(&self) -> bool { | ||
| self.len() == 0 |
There was a problem hiding this comment.
I would expect this to trigger clippy. Should this be:
Suggested change
| self.len() == 0 | |
| self.services.is_empty() |
There was a problem hiding this comment.
I'm not sure if ReadyCache actually has an is_empty, but it probably should if it does not...
There was a problem hiding this comment.
Uh good catch. Fixed in 5dc6044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I might as well fix the clippy warnings. Feel free to close this if you don't want the git churn.