Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use no-shadow of @typescript-eslint instead of base rule #71

Merged
merged 3 commits into from
Nov 21, 2020

Conversation

dohomi
Copy link
Contributor

@dohomi dohomi commented Nov 16, 2020

As stated here:
typescript-eslint/typescript-eslint#2484 (comment)
I added the two missing rules for v4 that enables the correct use for enum

Besides I ported the interface to a standalone file to make sure that the eslint will work.

Copy link
Owner

@toshi-toma toshi-toma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Thanks!! 👍

@toshi-toma toshi-toma changed the title fix no-shadow on enum fix: use no-shadow of @typescript-eslint instead of base rule Nov 21, 2020
@toshi-toma toshi-toma merged commit 319683c into toshi-toma:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants