Merge pull request #2 from torvalds/master #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken1029
pushed a commit
to ken1029/linux
that referenced
this pull request
Dec 20, 2016
commit 18b43e8 upstream. trace_hardirqs_on_caller() in lockdep.c expects to be called before, not after interrupts are actually enabled. The following comment in kernel/locking/lockdep.c substantiates this claim: " /* * We're enabling irqs and according to our state above irqs weren't * already enabled, yet we find the hardware thinks they are in fact * enabled.. someone messed up their IRQ state tracing. */ " An example can be found in include/linux/irqflags.h: do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0) Without this change, we hit the following DEBUG_LOCKS_WARN_ON. [ 7.760000] ------------[ cut here ]------------ [ 7.760000] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2711 resume_user_mode_begin+0x48/0xf0 [ 7.770000] DEBUG_LOCKS_WARN_ON(!irqs_disabled()) [ 7.780000] Modules linked in: [ 7.780000] CPU: 0 PID: 1 Comm: init Not tainted 4.7.0-00003-gc668bb9-dirty torvalds#366 [ 7.790000] [ 7.790000] Stack Trace: [ 7.790000] arc_unwind_core.constprop.1+0xa4/0x118 [ 7.800000] warn_slowpath_fmt+0x72/0x158 [ 7.800000] resume_user_mode_begin+0x48/0xf0 [ 7.810000] ---[ end trace 6f6a7a8fae20d2f0 ]--- Signed-off-by: Daniel Mentz <[email protected]> Signed-off-by: Vineet Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
voipac-support
referenced
this pull request
in voipac/linux-fslc
Jan 15, 2017
[ Upstream commit 18b43e8 ] trace_hardirqs_on_caller() in lockdep.c expects to be called before, not after interrupts are actually enabled. The following comment in kernel/locking/lockdep.c substantiates this claim: " /* * We're enabling irqs and according to our state above irqs weren't * already enabled, yet we find the hardware thinks they are in fact * enabled.. someone messed up their IRQ state tracing. */ " An example can be found in include/linux/irqflags.h: do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0) Without this change, we hit the following DEBUG_LOCKS_WARN_ON. [ 7.760000] ------------[ cut here ]------------ [ 7.760000] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2711 resume_user_mode_begin+0x48/0xf0 [ 7.770000] DEBUG_LOCKS_WARN_ON(!irqs_disabled()) [ 7.780000] Modules linked in: [ 7.780000] CPU: 0 PID: 1 Comm: init Not tainted 4.7.0-00003-gc668bb9-dirty Freescale#366 [ 7.790000] [ 7.790000] Stack Trace: [ 7.790000] arc_unwind_core.constprop.1+0xa4/0x118 [ 7.800000] warn_slowpath_fmt+0x72/0x158 [ 7.800000] resume_user_mode_begin+0x48/0xf0 [ 7.810000] ---[ end trace 6f6a7a8fae20d2f0 ]--- Signed-off-by: Daniel Mentz <[email protected]> Cc: <[email protected]> Signed-off-by: Vineet Gupta <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
bradfa
pushed a commit
to bradfa/linux
that referenced
this pull request
Jan 17, 2017
commit 18b43e8 upstream. trace_hardirqs_on_caller() in lockdep.c expects to be called before, not after interrupts are actually enabled. The following comment in kernel/locking/lockdep.c substantiates this claim: " /* * We're enabling irqs and according to our state above irqs weren't * already enabled, yet we find the hardware thinks they are in fact * enabled.. someone messed up their IRQ state tracing. */ " An example can be found in include/linux/irqflags.h: do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0) Without this change, we hit the following DEBUG_LOCKS_WARN_ON. [ 7.760000] ------------[ cut here ]------------ [ 7.760000] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2711 resume_user_mode_begin+0x48/0xf0 [ 7.770000] DEBUG_LOCKS_WARN_ON(!irqs_disabled()) [ 7.780000] Modules linked in: [ 7.780000] CPU: 0 PID: 1 Comm: init Not tainted 4.7.0-00003-gc668bb9-dirty torvalds#366 [ 7.790000] [ 7.790000] Stack Trace: [ 7.790000] arc_unwind_core.constprop.1+0xa4/0x118 [ 7.800000] warn_slowpath_fmt+0x72/0x158 [ 7.800000] resume_user_mode_begin+0x48/0xf0 [ 7.810000] ---[ end trace 6f6a7a8fae20d2f0 ]--- Signed-off-by: Daniel Mentz <[email protected]> Signed-off-by: Vineet Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
amery
pushed a commit
to linux-sunxi/linux-sunxi
that referenced
this pull request
Apr 4, 2017
[ Upstream commit 18b43e8 ] trace_hardirqs_on_caller() in lockdep.c expects to be called before, not after interrupts are actually enabled. The following comment in kernel/locking/lockdep.c substantiates this claim: " /* * We're enabling irqs and according to our state above irqs weren't * already enabled, yet we find the hardware thinks they are in fact * enabled.. someone messed up their IRQ state tracing. */ " An example can be found in include/linux/irqflags.h: do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0) Without this change, we hit the following DEBUG_LOCKS_WARN_ON. [ 7.760000] ------------[ cut here ]------------ [ 7.760000] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2711 resume_user_mode_begin+0x48/0xf0 [ 7.770000] DEBUG_LOCKS_WARN_ON(!irqs_disabled()) [ 7.780000] Modules linked in: [ 7.780000] CPU: 0 PID: 1 Comm: init Not tainted 4.7.0-00003-gc668bb9-dirty torvalds#366 [ 7.790000] [ 7.790000] Stack Trace: [ 7.790000] arc_unwind_core.constprop.1+0xa4/0x118 [ 7.800000] warn_slowpath_fmt+0x72/0x158 [ 7.800000] resume_user_mode_begin+0x48/0xf0 [ 7.810000] ---[ end trace 6f6a7a8fae20d2f0 ]--- Signed-off-by: Daniel Mentz <[email protected]> Cc: <[email protected]> Signed-off-by: Vineet Gupta <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
Mic92
pushed a commit
to Mic92/linux
that referenced
this pull request
Feb 4, 2019
Enabling system calls hijacking when using Node.js applications - tes…
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Feb 16, 2020
When stat query is requested(dev_get_stats()), bonding interfaces
collect stats of slave interfaces.
Then, it prints delta value, which is "new_stats - old_stats" and
updates bond->bond_stats.
But, this mechanism has some problems.
1. It needs a lock for protecting "bond->bond_stats".
Bonding interfaces would be nested. So this lock would also be nested.
So, spin_lock_nested() or dynamic lockdep class key was used.
In the case of spin_lock_nested(), it needs correct nested level value
and this value will be changed when master/nomaster operations
(ip link set bond0 master bond1) are being executed.
This value is protected by RTNL mutex lock, but "dev_get_stats()" would
be called outside of RTNL mutex.
So, imbalance lock/unlock would be happened.
Another case, which is to use dynamic lockdep class key has same problem.
dynamic lockdep class key is protected by RTNL mutex lock
and if master/nomaster operations are executed, updating lockdep class
key is needed.
But, dev_get_stats() would be called outside of RTNL mutex, so imbalance
lock/unlock would be happened too.
2. Couldn't show correct stats value when slave interfaces are used
directly.
Test commands:
ip netns add nst
ip link add veth0 type veth peer name veth1
ip link set veth1 netns nst
ip link add bond0 type bond
ip link set veth0 master bond0
ip netns exec nst ip link set veth1 up
ip netns exec nst ip a a 192.168.100.2/24 dev veth1
ip a a 192.168.100.1/24 dev bond0
ip link set veth0 up
ip link set bond0 up
ping 192.168.100.2 -I veth0 -c 10
ip -s link show bond0
ip -s link show veth0
Before:
26: bond0:
RX: bytes packets errors dropped overrun mcast
656 8 0 0 0 0
TX: bytes packets errors dropped carrier collsns
1340 22 0 0 0 0
~~~~~~~~~~~~
25: veth0@if24:
RX: bytes packets errors dropped overrun mcast
656 8 0 0 0 0
TX: bytes packets errors dropped carrier collsns
1340 22 0 0 0 0
~~~~~~~~~~~~
After:
19: bond0:
RX: bytes packets errors dropped overrun mcast
544 8 0 0 0 8
TX: bytes packets errors dropped carrier collsns
746 9 0 0 0 0
~~~~~~~~~~~
18: veth0@if17:
link/ether 76:14:ee:f1:7d:8e brd ff:ff:ff:ff:ff:ff link-netns nst
RX: bytes packets errors dropped overrun mcast
656 8 0 0 0 0
TX: bytes packets errors dropped carrier collsns
1250 21 0 0 0 0
~~~~~~~~~~~~
Only veth0 interface is used by ping process directly. bond0 interface
isn't used. So, bond0 stats should not be increased.
But, bond0 collects stats value of slave interface.
So bond0 stats will be increased.
In order to fix the above problems, this patch makes bonding interfaces
record own stats data like other interfaces.
This patch is made based on team interface stats logic.
There is another problem.
When master/nomaster operations are being executed, updating a dynamic
lockdep class key is needed.
But, bonding doesn't update dynamic lockdep key.
So, lockdep warning message occurs.
But, this problem will be disappeared by this patch.
Because this patch removes stats_lock and a dynamic lockdep class key
for stats_lock, which is stats_lock_key.
Test commands:
ip link add bond0 type bond
ip link add bond1 type bond
ip link set bond0 master bond1
ip link set bond0 nomaster
ip link set bond1 master bond0
Splat looks like:
[ 316.354460][ T1170] WARNING: possible circular locking dependency detected
[ 316.355240][ T1170] 5.5.0+ torvalds#366 Not tainted
[ 316.355720][ T1170] ------------------------------------------------------
[ 316.357345][ T1170] ip/1170 is trying to acquire lock:
[ 316.358007][ T1170] ffff8880ca79acd8 (&bond->stats_lock_key#2){+.+.}, at: bond_get_stats+0x90/0x4d0 [bonding]
[ 316.359544][ T1170]
[ 316.359544][ T1170] but task is already holding lock:
[ 316.360578][ T1170] ffff8880b12f2cd8 (&bond->stats_lock_key){+.+.}, at: bond_get_stats+0x90/0x4d0 [bonding]
[ 316.361992][ T1170]
[ 316.361992][ T1170] which lock already depends on the new lock.
[ 316.361992][ T1170]
[ 316.363446][ T1170]
[ 316.363446][ T1170] the existing dependency chain (in reverse order) is:
[ 316.364739][ T1170]
[ 316.364739][ T1170] -> #1 (&bond->stats_lock_key){+.+.}:
[ 316.366686][ T1170] _raw_spin_lock+0x30/0x70
[ 316.367394][ T1170] bond_get_stats+0x90/0x4d0 [bonding]
[ 316.368202][ T1170] dev_get_stats+0x1ec/0x270
[ 316.368890][ T1170] bond_get_stats+0x1a5/0x4d0 [bonding]
[ 316.370573][ T1170] dev_get_stats+0x1ec/0x270
[ 316.371227][ T1170] rtnl_fill_stats+0x44/0xbe0
[ 316.371891][ T1170] rtnl_fill_ifinfo+0xeb2/0x3720
[ 316.372619][ T1170] rtmsg_ifinfo_build_skb+0xca/0x170
[ 316.373371][ T1170] rtmsg_ifinfo_event.part.33+0x1b/0xb0
[ 316.374161][ T1170] rtnetlink_event+0xcd/0x120
[ 316.375112][ T1170] notifier_call_chain+0x90/0x160
[ 316.375680][ T1170] netdev_change_features+0x74/0xa0
[ 316.376417][ T1170] bond_compute_features.isra.45+0x4e6/0x6f0 [bonding]
[ 316.378357][ T1170] bond_enslave+0x3639/0x47b0 [bonding]
[ 316.379138][ T1170] do_setlink+0xaab/0x2ef0
[ 316.379757][ T1170] __rtnl_newlink+0x9c5/0x1270
[ 316.380486][ T1170] rtnl_newlink+0x65/0x90
[ 316.381271][ T1170] rtnetlink_rcv_msg+0x4a8/0x890
[ 316.382138][ T1170] netlink_rcv_skb+0x121/0x350
[ 316.382793][ T1170] netlink_unicast+0x42e/0x610
[ 316.383507][ T1170] netlink_sendmsg+0x65a/0xb90
[ 316.384398][ T1170] ____sys_sendmsg+0x5ce/0x7a0
[ 316.385084][ T1170] ___sys_sendmsg+0x10f/0x1b0
[ 316.385778][ T1170] __sys_sendmsg+0xc6/0x150
[ 316.386469][ T1170] do_syscall_64+0x99/0x4f0
[ 316.387185][ T1170] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[ 316.388000][ T1170]
[ 316.388000][ T1170] -> #0 (&bond->stats_lock_key#2){+.+.}:
[ 316.389019][ T1170] __lock_acquire+0x2d8d/0x3de0
[ 316.392598][ T1170] lock_acquire+0x164/0x3b0
[ 316.393309][ T1170] _raw_spin_lock+0x30/0x70
[ 316.393962][ T1170] bond_get_stats+0x90/0x4d0 [bonding]
[ 316.394787][ T1170] dev_get_stats+0x1ec/0x270
[ 316.395496][ T1170] bond_get_stats+0x1a5/0x4d0 [bonding]
[ 316.396285][ T1170] dev_get_stats+0x1ec/0x270
[ 316.396949][ T1170] rtnl_fill_stats+0x44/0xbe0
[ 316.400420][ T1170] rtnl_fill_ifinfo+0xeb2/0x3720
[ 316.401122][ T1170] rtmsg_ifinfo_build_skb+0xca/0x170
[ 316.401933][ T1170] rtmsg_ifinfo_event.part.33+0x1b/0xb0
[ 316.402739][ T1170] rtnetlink_event+0xcd/0x120
[ 316.403477][ T1170] notifier_call_chain+0x90/0x160
[ 316.404187][ T1170] netdev_change_features+0x74/0xa0
[ 316.404957][ T1170] bond_compute_features.isra.45+0x4e6/0x6f0 [bonding]
[ 316.405978][ T1170] bond_enslave+0x3639/0x47b0 [bonding]
[ 316.406780][ T1170] do_setlink+0xaab/0x2ef0
[ 316.407441][ T1170] __rtnl_newlink+0x9c5/0x1270
[ 316.408152][ T1170] rtnl_newlink+0x65/0x90
[ 316.408788][ T1170] rtnetlink_rcv_msg+0x4a8/0x890
[ 316.411550][ T1170] netlink_rcv_skb+0x121/0x350
[ 316.412230][ T1170] netlink_unicast+0x42e/0x610
[ 316.412897][ T1170] netlink_sendmsg+0x65a/0xb90
[ 316.413703][ T1170] ____sys_sendmsg+0x5ce/0x7a0
[ 316.414448][ T1170] ___sys_sendmsg+0x10f/0x1b0
[ 316.415129][ T1170] __sys_sendmsg+0xc6/0x150
[ 316.415801][ T1170] do_syscall_64+0x99/0x4f0
[ 316.416491][ T1170] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[ 316.417407][ T1170]
[ 316.417407][ T1170] other info that might help us debug this:
[ 316.417407][ T1170]
[ 316.418728][ T1170] Possible unsafe locking scenario:
[ 316.418728][ T1170]
[ 316.419693][ T1170] CPU0 CPU1
[ 316.420400][ T1170] ---- ----
[ 316.421096][ T1170] lock(&bond->stats_lock_key);
[ 316.421821][ T1170] lock(&bond->stats_lock_key#2);
[ 316.422819][ T1170] lock(&bond->stats_lock_key);
[ 316.424906][ T1170] lock(&bond->stats_lock_key#2);
[ 316.425596][ T1170]
[ 316.425596][ T1170] *** DEADLOCK ***
[ 316.425596][ T1170]
[ 316.426726][ T1170] 3 locks held by ip/1170:
[ 316.427351][ T1170] #0: ffffffffa2cf60f0 (rtnl_mutex){+.+.}, at: rtnetlink_rcv_msg+0x457/0x890
[ 316.428556][ T1170] #1: ffff8880b12f2cd8 (&bond->stats_lock_key){+.+.}, at: bond_get_stats+0x90/0x4d0 [bondin]
[ 316.431170][ T1170] #2: ffffffffa29254c0 (rcu_read_lock){....}, at: bond_get_stats+0x5/0x4d0 [bonding]
[ 316.432411][ T1170]
[ 316.432411][ T1170] stack backtrace:
[ 316.433341][ T1170] CPU: 3 PID: 1170 Comm: ip Not tainted 5.5.0+ torvalds#366
[ 316.434208][ T1170] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
[ 316.435367][ T1170] Call Trace:
[ 316.435846][ T1170] dump_stack+0x96/0xdb
[ 316.436449][ T1170] check_noncircular+0x371/0x450
[ 316.437101][ T1170] ? print_circular_bug.isra.35+0x310/0x310
[ 316.437895][ T1170] ? hlock_class+0x130/0x130
[ 316.438531][ T1170] ? __lock_acquire+0x2d8d/0x3de0
[ 316.439241][ T1170] __lock_acquire+0x2d8d/0x3de0
[ 316.439889][ T1170] ? register_lock_class+0x14d0/0x14d0
[ 316.440602][ T1170] ? check_chain_key+0x236/0x5d0
[ 316.442135][ T1170] lock_acquire+0x164/0x3b0
[ 316.442789][ T1170] ? bond_get_stats+0x90/0x4d0 [bonding]
[ 316.443524][ T1170] _raw_spin_lock+0x30/0x70
[ 316.444112][ T1170] ? bond_get_stats+0x90/0x4d0 [bonding]
[ 316.445571][ T1170] bond_get_stats+0x90/0x4d0 [bonding]
[ 316.446320][ T1170] ? bond_neigh_init+0x2d0/0x2d0 [bonding]
[ 316.447330][ T1170] ? rcu_read_lock_held+0x90/0xa0
[ 316.448003][ T1170] ? rcu_read_lock_sched_held+0xc0/0xc0
[ 316.450802][ T1170] ? bond_get_stats+0x5/0x4d0 [bonding]
[ 316.451569][ T1170] dev_get_stats+0x1ec/0x270
[ 316.452206][ T1170] bond_get_stats+0x1a5/0x4d0 [bonding]
[ ... ]
Fixes: 089bca2 ("bonding: use dynamic lockdep key instead of subclass")
Signed-off-by: Taehee Yoo <[email protected]>
samueldr
pushed a commit
to samueldr/linux
that referenced
this pull request
Jun 28, 2020
[ Upstream commit 18b43e8 ] trace_hardirqs_on_caller() in lockdep.c expects to be called before, not after interrupts are actually enabled. The following comment in kernel/locking/lockdep.c substantiates this claim: " /* * We're enabling irqs and according to our state above irqs weren't * already enabled, yet we find the hardware thinks they are in fact * enabled.. someone messed up their IRQ state tracing. */ " An example can be found in include/linux/irqflags.h: do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0) Without this change, we hit the following DEBUG_LOCKS_WARN_ON. [ 7.760000] ------------[ cut here ]------------ [ 7.760000] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2711 resume_user_mode_begin+0x48/0xf0 [ 7.770000] DEBUG_LOCKS_WARN_ON(!irqs_disabled()) [ 7.780000] Modules linked in: [ 7.780000] CPU: 0 PID: 1 Comm: init Not tainted 4.7.0-00003-gc668bb9-dirty torvalds#366 [ 7.790000] [ 7.790000] Stack Trace: [ 7.790000] arc_unwind_core.constprop.1+0xa4/0x118 [ 7.800000] warn_slowpath_fmt+0x72/0x158 [ 7.800000] resume_user_mode_begin+0x48/0xf0 [ 7.810000] ---[ end trace 6f6a7a8fae20d2f0 ]--- Signed-off-by: Daniel Mentz <[email protected]> Cc: <[email protected]> Signed-off-by: Vineet Gupta <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 12, 2021
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
torvalds#47: FILE: hal/HalBtcOutSrc.h:47:
+typedef enum _BTC_POWERSAVE_TYPE {
WARNING: do not add new typedefs
torvalds#54: FILE: hal/HalBtcOutSrc.h:54:
+typedef enum _BTC_BT_REG_TYPE {
WARNING: do not add new typedefs
torvalds#63: FILE: hal/HalBtcOutSrc.h:63:
+typedef enum _BTC_CHIP_INTERFACE {
WARNING: do not add new typedefs
torvalds#71: FILE: hal/HalBtcOutSrc.h:71:
+typedef enum _BTC_CHIP_TYPE {
WARNING: do not add new typedefs
torvalds#81: FILE: hal/HalBtcOutSrc.h:81:
+typedef enum _BTC_MSG_TYPE {
WARNING: do not add new typedefs
torvalds#167: FILE: hal/HalBtcOutSrc.h:167:
+typedef struct _BTC_BOARD_INFO {
WARNING: do not add new typedefs
torvalds#177: FILE: hal/HalBtcOutSrc.h:177:
+typedef enum _BTC_DBG_OPCODE {
WARNING: do not add new typedefs
torvalds#187: FILE: hal/HalBtcOutSrc.h:187:
+typedef enum _BTC_RSSI_STATE {
WARNING: do not add new typedefs
torvalds#200: FILE: hal/HalBtcOutSrc.h:200:
+typedef enum _BTC_WIFI_ROLE {
WARNING: do not add new typedefs
torvalds#208: FILE: hal/HalBtcOutSrc.h:208:
+typedef enum _BTC_WIFI_BW_MODE {
WARNING: do not add new typedefs
torvalds#215: FILE: hal/HalBtcOutSrc.h:215:
+typedef enum _BTC_WIFI_TRAFFIC_DIR {
WARNING: do not add new typedefs
torvalds#221: FILE: hal/HalBtcOutSrc.h:221:
+typedef enum _BTC_WIFI_PNP {
WARNING: do not add new typedefs
torvalds#228: FILE: hal/HalBtcOutSrc.h:228:
+typedef enum _BT_WIFI_COEX_STATE {
WARNING: do not add new typedefs
torvalds#239: FILE: hal/HalBtcOutSrc.h:239:
+typedef enum _BTC_GET_TYPE {
WARNING: do not add new typedefs
torvalds#281: FILE: hal/HalBtcOutSrc.h:281:
+typedef enum _BTC_SET_TYPE {
WARNING: do not add new typedefs
torvalds#321: FILE: hal/HalBtcOutSrc.h:321:
+typedef enum _BTC_DBG_DISP_TYPE {
WARNING: do not add new typedefs
torvalds#328: FILE: hal/HalBtcOutSrc.h:328:
+typedef enum _BTC_NOTIFY_TYPE_IPS {
WARNING: do not add new typedefs
torvalds#334: FILE: hal/HalBtcOutSrc.h:334:
+typedef enum _BTC_NOTIFY_TYPE_LPS {
WARNING: do not add new typedefs
torvalds#340: FILE: hal/HalBtcOutSrc.h:340:
+typedef enum _BTC_NOTIFY_TYPE_SCAN {
WARNING: do not add new typedefs
torvalds#346: FILE: hal/HalBtcOutSrc.h:346:
+typedef enum _BTC_NOTIFY_TYPE_ASSOCIATE {
WARNING: do not add new typedefs
torvalds#352: FILE: hal/HalBtcOutSrc.h:352:
+typedef enum _BTC_NOTIFY_TYPE_MEDIA_STATUS {
WARNING: do not add new typedefs
torvalds#358: FILE: hal/HalBtcOutSrc.h:358:
+typedef enum _BTC_NOTIFY_TYPE_SPECIAL_PACKET {
WARNING: do not add new typedefs
torvalds#366: FILE: hal/HalBtcOutSrc.h:366:
+typedef enum _BTC_NOTIFY_TYPE_STACK_OPERATION {
WARNING: do not add new typedefs
torvalds#374: FILE: hal/HalBtcOutSrc.h:374:
+typedef enum _BTC_ANTENNA_POS {
WARNING: do not add new typedefs
torvalds#412: FILE: hal/HalBtcOutSrc.h:412:
+typedef struct _BTC_BT_INFO {
WARNING: do not add new typedefs
torvalds#440: FILE: hal/HalBtcOutSrc.h:440:
+typedef struct _BTC_STACK_INFO {
WARNING: do not add new typedefs
torvalds#455: FILE: hal/HalBtcOutSrc.h:455:
+typedef struct _BTC_BT_LINK_INFO {
WARNING: do not add new typedefs
torvalds#468: FILE: hal/HalBtcOutSrc.h:468:
+typedef struct _BTC_STATISTICS {
WARNING: do not add new typedefs
torvalds#487: FILE: hal/HalBtcOutSrc.h:487:
+typedef struct _BTC_COEXIST {
Signed-off-by: Marco Cesati <[email protected]>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 13, 2021
This commit fixes the following checkpatch.pl warnings:
WARNING: do not add new typedefs
torvalds#47: FILE: hal/HalBtcOutSrc.h:47:
+typedef enum _BTC_POWERSAVE_TYPE {
WARNING: do not add new typedefs
torvalds#54: FILE: hal/HalBtcOutSrc.h:54:
+typedef enum _BTC_BT_REG_TYPE {
WARNING: do not add new typedefs
torvalds#63: FILE: hal/HalBtcOutSrc.h:63:
+typedef enum _BTC_CHIP_INTERFACE {
WARNING: do not add new typedefs
torvalds#71: FILE: hal/HalBtcOutSrc.h:71:
+typedef enum _BTC_CHIP_TYPE {
WARNING: do not add new typedefs
torvalds#81: FILE: hal/HalBtcOutSrc.h:81:
+typedef enum _BTC_MSG_TYPE {
WARNING: do not add new typedefs
torvalds#167: FILE: hal/HalBtcOutSrc.h:167:
+typedef struct _BTC_BOARD_INFO {
WARNING: do not add new typedefs
torvalds#177: FILE: hal/HalBtcOutSrc.h:177:
+typedef enum _BTC_DBG_OPCODE {
WARNING: do not add new typedefs
torvalds#187: FILE: hal/HalBtcOutSrc.h:187:
+typedef enum _BTC_RSSI_STATE {
WARNING: do not add new typedefs
torvalds#200: FILE: hal/HalBtcOutSrc.h:200:
+typedef enum _BTC_WIFI_ROLE {
WARNING: do not add new typedefs
torvalds#208: FILE: hal/HalBtcOutSrc.h:208:
+typedef enum _BTC_WIFI_BW_MODE {
WARNING: do not add new typedefs
torvalds#215: FILE: hal/HalBtcOutSrc.h:215:
+typedef enum _BTC_WIFI_TRAFFIC_DIR {
WARNING: do not add new typedefs
torvalds#221: FILE: hal/HalBtcOutSrc.h:221:
+typedef enum _BTC_WIFI_PNP {
WARNING: do not add new typedefs
torvalds#228: FILE: hal/HalBtcOutSrc.h:228:
+typedef enum _BT_WIFI_COEX_STATE {
WARNING: do not add new typedefs
torvalds#239: FILE: hal/HalBtcOutSrc.h:239:
+typedef enum _BTC_GET_TYPE {
WARNING: do not add new typedefs
torvalds#281: FILE: hal/HalBtcOutSrc.h:281:
+typedef enum _BTC_SET_TYPE {
WARNING: do not add new typedefs
torvalds#321: FILE: hal/HalBtcOutSrc.h:321:
+typedef enum _BTC_DBG_DISP_TYPE {
WARNING: do not add new typedefs
torvalds#328: FILE: hal/HalBtcOutSrc.h:328:
+typedef enum _BTC_NOTIFY_TYPE_IPS {
WARNING: do not add new typedefs
torvalds#334: FILE: hal/HalBtcOutSrc.h:334:
+typedef enum _BTC_NOTIFY_TYPE_LPS {
WARNING: do not add new typedefs
torvalds#340: FILE: hal/HalBtcOutSrc.h:340:
+typedef enum _BTC_NOTIFY_TYPE_SCAN {
WARNING: do not add new typedefs
torvalds#346: FILE: hal/HalBtcOutSrc.h:346:
+typedef enum _BTC_NOTIFY_TYPE_ASSOCIATE {
WARNING: do not add new typedefs
torvalds#352: FILE: hal/HalBtcOutSrc.h:352:
+typedef enum _BTC_NOTIFY_TYPE_MEDIA_STATUS {
WARNING: do not add new typedefs
torvalds#358: FILE: hal/HalBtcOutSrc.h:358:
+typedef enum _BTC_NOTIFY_TYPE_SPECIAL_PACKET {
WARNING: do not add new typedefs
torvalds#366: FILE: hal/HalBtcOutSrc.h:366:
+typedef enum _BTC_NOTIFY_TYPE_STACK_OPERATION {
WARNING: do not add new typedefs
torvalds#374: FILE: hal/HalBtcOutSrc.h:374:
+typedef enum _BTC_ANTENNA_POS {
WARNING: do not add new typedefs
torvalds#412: FILE: hal/HalBtcOutSrc.h:412:
+typedef struct _BTC_BT_INFO {
WARNING: do not add new typedefs
torvalds#440: FILE: hal/HalBtcOutSrc.h:440:
+typedef struct _BTC_STACK_INFO {
WARNING: do not add new typedefs
torvalds#455: FILE: hal/HalBtcOutSrc.h:455:
+typedef struct _BTC_BT_LINK_INFO {
WARNING: do not add new typedefs
torvalds#468: FILE: hal/HalBtcOutSrc.h:468:
+typedef struct _BTC_STATISTICS {
WARNING: do not add new typedefs
torvalds#487: FILE: hal/HalBtcOutSrc.h:487:
+typedef struct _BTC_COEXIST {
Signed-off-by: Marco Cesati <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 15, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#14: FILE: ./hal/odm_DIG.c:14:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#30: FILE: ./hal/odm_DIG.c:30:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#41: FILE: ./hal/odm_DIG.c:41:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#51: FILE: ./hal/odm_DIG.c:51:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#59: FILE: ./hal/odm_DIG.c:59:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#72: FILE: ./hal/odm_DIG.c:72:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#136: FILE: ./hal/odm_DIG.c:136:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#208: FILE: ./hal/odm_DIG.c:208:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#236: FILE: ./hal/odm_DIG.c:236:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#325: FILE: ./hal/odm_DIG.c:325:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#326: FILE: ./hal/odm_DIG.c:326:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#365: FILE: ./hal/odm_DIG.c:365:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#366: FILE: ./hal/odm_DIG.c:366:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#438: FILE: ./hal/odm_DIG.c:438:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#469: FILE: ./hal/odm_DIG.c:469:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#470: FILE: ./hal/odm_DIG.c:470:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#507: FILE: ./hal/odm_DIG.c:507:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#510: FILE: ./hal/odm_DIG.c:510:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#826: FILE: ./hal/odm_DIG.c:826:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#895: FILE: ./hal/odm_DIG.c:895:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#896: FILE: ./hal/odm_DIG.c:896:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1065: FILE: ./hal/odm_DIG.c:1065:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1081: FILE: ./hal/odm_DIG.c:1081:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1082: FILE: ./hal/odm_DIG.c:1082:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1083: FILE: ./hal/odm_DIG.c:1083:
+ struct false_ALARM_STATISTICS * pFalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1137: FILE: ./hal/odm_DIG.c:1137:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1138: FILE: ./hal/odm_DIG.c:1138:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1198: FILE: ./hal/odm_DIG.c:1198:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1199: FILE: ./hal/odm_DIG.c:1199:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
Signed-off-by: Marco Cesati <[email protected]>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 16, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#14: FILE: ./hal/odm_DIG.c:14:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#30: FILE: ./hal/odm_DIG.c:30:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#41: FILE: ./hal/odm_DIG.c:41:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#51: FILE: ./hal/odm_DIG.c:51:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#59: FILE: ./hal/odm_DIG.c:59:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#72: FILE: ./hal/odm_DIG.c:72:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#136: FILE: ./hal/odm_DIG.c:136:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#208: FILE: ./hal/odm_DIG.c:208:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#236: FILE: ./hal/odm_DIG.c:236:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#325: FILE: ./hal/odm_DIG.c:325:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#326: FILE: ./hal/odm_DIG.c:326:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#365: FILE: ./hal/odm_DIG.c:365:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#366: FILE: ./hal/odm_DIG.c:366:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#438: FILE: ./hal/odm_DIG.c:438:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#469: FILE: ./hal/odm_DIG.c:469:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#470: FILE: ./hal/odm_DIG.c:470:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#507: FILE: ./hal/odm_DIG.c:507:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#510: FILE: ./hal/odm_DIG.c:510:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#826: FILE: ./hal/odm_DIG.c:826:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#895: FILE: ./hal/odm_DIG.c:895:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#896: FILE: ./hal/odm_DIG.c:896:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1065: FILE: ./hal/odm_DIG.c:1065:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1081: FILE: ./hal/odm_DIG.c:1081:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1082: FILE: ./hal/odm_DIG.c:1082:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1083: FILE: ./hal/odm_DIG.c:1083:
+ struct false_ALARM_STATISTICS * pFalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1137: FILE: ./hal/odm_DIG.c:1137:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1138: FILE: ./hal/odm_DIG.c:1138:
+ struct false_ALARM_STATISTICS * FalseAlmCnt = &(pDM_Odm->FalseAlmCnt);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1198: FILE: ./hal/odm_DIG.c:1198:
+ struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1199: FILE: ./hal/odm_DIG.c:1199:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Marco Cesati <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
ojeda
pushed a commit
to ojeda/linux
that referenced
this pull request
Jun 9, 2021
binder: fix use-before-init of spinlock
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
Aug 29, 2022
Fix the following OOPS: BUG: kernel NULL pointer dereference, address: 0000000000000000 PGD 0 P4D 0 Oops: 0010 [#1] PREEMPT SMP CPU: 14 PID: 1156 Comm: upowerd Tainted: G S U 6.0.0-rc1+ torvalds#366 Hardware name: LENOVO 20Y5CTO1WW/20Y5CTO1WW, BIOS N40ET36W (1.18 ) 07/19/2022 RIP: 0010:0x0 Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. RSP: 0018:ffff88815350bd08 EFLAGS: 00010212 RAX: ffff88810207d620 RBX: ffff88815350bd7c RCX: 000000000000394e RDX: ffff88815350bd10 RSI: 0000000000000004 RDI: ffff888111722c00 RBP: ffff88815350bd68 R08: ffff8881187a8af8 R09: ffff8881187a8af8 R10: 0000000000000000 R11: 000000000000005f R12: ffffffff8162d0b0 R13: ffff88810159a038 R14: ffffffff823b3768 R15: ffff88810159a000 FS: 00007fd1f0958140(0000) GS:ffff88901f780000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffd6 CR3: 0000000152c7a004 CR4: 0000000000770ee0 PKRU: 55555554 Call Trace: <TASK> __power_supply_is_system_supplied+0x26/0x40 class_for_each_device+0xa5/0xd0 ? acpi_battery_get_state+0x4e/0x1f0 power_supply_is_system_supplied+0x26/0x40 acpi_battery_get_property+0x301/0x310 power_supply_show_property+0xa5/0x1d0 dev_attr_show+0x10/0x30 sysfs_kf_seq_show+0x78/0xc0 seq_read_iter+0xfd/0x3e0 vfs_read+0x1cb/0x290 ksys_read+0x4e/0xc0 do_syscall_64+0x2b/0x50 entry_SYSCALL_64_after_hwframe+0x46/0xb0 RIP: 0033:0x7fd1f0bed70c Code: ec 28 48 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 39 a4 f8 ff 41 89 c0 48 8b 54 24 18 48 8b 74 24 10 8b 7c 24 08 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 34 44 89 c7 48 89 44 24 08 e8 8f a4 f8 ff 48 RSP: 002b:00007ffc8d3f27e0 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fd1f0bed70c RDX: 0000000000001000 RSI: 000055957d534850 RDI: 000000000000000c RBP: 000055957d50b1d0 R08: 0000000000000000 R09: 0000000000001000 R10: 000000000000006f R11: 0000000000000246 R12: 00007ffc8d3f2910 R13: 0000000000000000 R14: 0000000000000000 R15: 000000000000000c </TASK> CR2: 0000000000000000 ---[ end trace 0000000000000000 ]--- RIP: 0010:0x0 Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. RSP: 0018:ffff88815350bd08 EFLAGS: 00010212 RAX: ffff88810207d620 RBX: ffff88815350bd7c RCX: 000000000000394e RDX: ffff88815350bd10 RSI: 0000000000000004 RDI: ffff888111722c00 RBP: ffff88815350bd68 R08: ffff8881187a8af8 R09: ffff8881187a8af8 R10: 0000000000000000 R11: 000000000000005f R12: ffffffff8162d0b0 R13: ffff88810159a038 R14: ffffffff823b3768 R15: ffff88810159a000 FS: 00007fd1f0958140(0000) GS:ffff88901f780000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffd6 CR3: 0000000152c7a004 CR4: 0000000000770ee0 The disassembly of the top function in the stack trace is: .text:0000000000000000 __power_supply_is_system_supplied proc near .text:0000000000000000 ; DATA XREF: power_supply_is_system_supplied+12↓o .text:0000000000000000 .text:0000000000000000 var_8 = qword ptr -8 .text:0000000000000000 .text:0000000000000000 sub rsp, 8 .text:0000000000000004 mov rdi, [rdi+78h] .text:0000000000000008 inc dword ptr [rsi] .text:000000000000000A mov [rsp+8+var_8], 0 .text:0000000000000012 mov rax, [rdi] .text:0000000000000015 cmp dword ptr [rax+8], 1 .text:0000000000000019 jz short loc_2A .text:000000000000001B mov rdx, rsp .text:000000000000001E mov esi, 4 .text:0000000000000023 call qword ptr [rax+30h] .text:0000000000000026 test eax, eax .text:0000000000000028 jz short loc_31 .text:000000000000002A .text:000000000000002A loc_2A: ; CODE XREF: __power_supply_is_system_supplied+19↑j .text:000000000000002A xor eax, eax .text:000000000000002C add rsp, 8 .text:0000000000000030 retn .text:0000000000000031 ; --------------------------------------------------------------------------- .text:0000000000000031 .text:0000000000000031 loc_31: ; CODE XREF: __power_supply_is_system_supplied+28↑j .text:0000000000000031 mov eax, dword ptr [rsp+8+var_8] .text:0000000000000034 add rsp, 8 .text:0000000000000038 retn .text:0000000000000038 __power_supply_is_system_supplied endp So presumably `call qword ptr [rax+30h]` is jumping to NULL. Cc: [email protected] Cc: Rafael J. Wysocki <[email protected]> Signed-off-by: Jason A. Donenfeld <[email protected]>
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
Sep 12, 2022
Fix the following OOPS: BUG: kernel NULL pointer dereference, address: 0000000000000000 PGD 0 P4D 0 Oops: 0010 [#1] PREEMPT SMP CPU: 14 PID: 1156 Comm: upowerd Tainted: G S U 6.0.0-rc1+ torvalds#366 Hardware name: LENOVO 20Y5CTO1WW/20Y5CTO1WW, BIOS N40ET36W (1.18 ) 07/19/2022 RIP: 0010:0x0 Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. RSP: 0018:ffff88815350bd08 EFLAGS: 00010212 RAX: ffff88810207d620 RBX: ffff88815350bd7c RCX: 000000000000394e RDX: ffff88815350bd10 RSI: 0000000000000004 RDI: ffff888111722c00 RBP: ffff88815350bd68 R08: ffff8881187a8af8 R09: ffff8881187a8af8 R10: 0000000000000000 R11: 000000000000005f R12: ffffffff8162d0b0 R13: ffff88810159a038 R14: ffffffff823b3768 R15: ffff88810159a000 FS: 00007fd1f0958140(0000) GS:ffff88901f780000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffd6 CR3: 0000000152c7a004 CR4: 0000000000770ee0 PKRU: 55555554 Call Trace: <TASK> __power_supply_is_system_supplied+0x26/0x40 class_for_each_device+0xa5/0xd0 ? acpi_battery_get_state+0x4e/0x1f0 power_supply_is_system_supplied+0x26/0x40 acpi_battery_get_property+0x301/0x310 power_supply_show_property+0xa5/0x1d0 dev_attr_show+0x10/0x30 sysfs_kf_seq_show+0x78/0xc0 seq_read_iter+0xfd/0x3e0 vfs_read+0x1cb/0x290 ksys_read+0x4e/0xc0 do_syscall_64+0x2b/0x50 entry_SYSCALL_64_after_hwframe+0x46/0xb0 RIP: 0033:0x7fd1f0bed70c Code: ec 28 48 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 39 a4 f8 ff 41 89 c0 48 8b 54 24 18 48 8b 74 24 10 8b 7c 24 08 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 34 44 89 c7 48 89 44 24 08 e8 8f a4 f8 ff 48 RSP: 002b:00007ffc8d3f27e0 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fd1f0bed70c RDX: 0000000000001000 RSI: 000055957d534850 RDI: 000000000000000c RBP: 000055957d50b1d0 R08: 0000000000000000 R09: 0000000000001000 R10: 000000000000006f R11: 0000000000000246 R12: 00007ffc8d3f2910 R13: 0000000000000000 R14: 0000000000000000 R15: 000000000000000c </TASK> CR2: 0000000000000000 ---[ end trace 0000000000000000 ]--- RIP: 0010:0x0 Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. RSP: 0018:ffff88815350bd08 EFLAGS: 00010212 RAX: ffff88810207d620 RBX: ffff88815350bd7c RCX: 000000000000394e RDX: ffff88815350bd10 RSI: 0000000000000004 RDI: ffff888111722c00 RBP: ffff88815350bd68 R08: ffff8881187a8af8 R09: ffff8881187a8af8 R10: 0000000000000000 R11: 000000000000005f R12: ffffffff8162d0b0 R13: ffff88810159a038 R14: ffffffff823b3768 R15: ffff88810159a000 FS: 00007fd1f0958140(0000) GS:ffff88901f780000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffd6 CR3: 0000000152c7a004 CR4: 0000000000770ee0 The disassembly of the top function in the stack trace is: .text:0000000000000000 __power_supply_is_system_supplied proc near .text:0000000000000000 ; DATA XREF: power_supply_is_system_supplied+12↓o .text:0000000000000000 .text:0000000000000000 var_8 = qword ptr -8 .text:0000000000000000 .text:0000000000000000 sub rsp, 8 .text:0000000000000004 mov rdi, [rdi+78h] .text:0000000000000008 inc dword ptr [rsi] .text:000000000000000A mov [rsp+8+var_8], 0 .text:0000000000000012 mov rax, [rdi] .text:0000000000000015 cmp dword ptr [rax+8], 1 .text:0000000000000019 jz short loc_2A .text:000000000000001B mov rdx, rsp .text:000000000000001E mov esi, 4 .text:0000000000000023 call qword ptr [rax+30h] .text:0000000000000026 test eax, eax .text:0000000000000028 jz short loc_31 .text:000000000000002A .text:000000000000002A loc_2A: ; CODE XREF: __power_supply_is_system_supplied+19↑j .text:000000000000002A xor eax, eax .text:000000000000002C add rsp, 8 .text:0000000000000030 retn .text:0000000000000031 ; --------------------------------------------------------------------------- .text:0000000000000031 .text:0000000000000031 loc_31: ; CODE XREF: __power_supply_is_system_supplied+28↑j .text:0000000000000031 mov eax, dword ptr [rsp+8+var_8] .text:0000000000000034 add rsp, 8 .text:0000000000000038 retn .text:0000000000000038 __power_supply_is_system_supplied endp So presumably `call qword ptr [rax+30h]` is jumping to NULL. Cc: [email protected] Acked-by: Rafael J. Wysocki <[email protected]> Signed-off-by: Jason A. Donenfeld <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]>
akiernan
pushed a commit
to zuma-array/linux
that referenced
this pull request
Nov 3, 2022
PD#152908: driver defect clean up torvalds#364 torvalds#365 torvalds#366 Change-Id: I53c4bd4cbe1cc82408ec3f0b30b3b8e696ea1fc2 Signed-off-by: Jiamin Ma <[email protected]>
akiernan
pushed a commit
to zuma-array/linux
that referenced
this pull request
Nov 4, 2022
PD#152908: driver defect clean up torvalds#364 torvalds#365 torvalds#366 Change-Id: I53c4bd4cbe1cc82408ec3f0b30b3b8e696ea1fc2 Signed-off-by: Jiamin Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge with torvalds/linux