Skip to content

Commit

Permalink
ARM: EXYNOS: Add missing of_node_put() when parsing power domains
Browse files Browse the repository at this point in the history
Add missing of_node_put() to:
1. Error return path if allocating memory for exynos_pm_domain failed.
2. Second iteration over power domains if a child domain was not
   present or was incomplete.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reported-by: Karol Wrona <[email protected]>
Signed-off-by: Kukjin Kim <[email protected]>
  • Loading branch information
krzk authored and Kukjin Kim committed Jun 5, 2015
1 parent c88cad3 commit fe4034a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions arch/arm/mach-exynos/pm_domains.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ static __init int exynos4_pm_init_power_domain(void)
if (!pd) {
pr_err("%s: failed to allocate memory for domain\n",
__func__);
of_node_put(np);
return -ENOMEM;
}

Expand Down Expand Up @@ -209,22 +210,23 @@ static __init int exynos4_pm_init_power_domain(void)
args.args_count = 0;
child_domain = of_genpd_get_from_provider(&args);
if (IS_ERR(child_domain))
continue;
goto next_pd;

if (of_parse_phandle_with_args(np, "power-domains",
"#power-domain-cells", 0, &args) != 0)
continue;
goto next_pd;

parent_domain = of_genpd_get_from_provider(&args);
if (IS_ERR(parent_domain))
continue;
goto next_pd;

if (pm_genpd_add_subdomain(parent_domain, child_domain))
pr_warn("%s failed to add subdomain: %s\n",
parent_domain->name, child_domain->name);
else
pr_info("%s has as child subdomain: %s.\n",
parent_domain->name, child_domain->name);
next_pd:
of_node_put(np);
}

Expand Down

0 comments on commit fe4034a

Please sign in to comment.